OCPBUGS-12202: Relax vsphere, nutanix VIP validation #7116

patrickdillon · 2023-04-20T20:36:10Z

Manual backport of #6915 and #6967

This commit removes validation to ensure the ingress and API vips are in the default machine network cidr. This validation was added to all on-prem platforms. Installs have worked without this validation since the release of openshift 4 and the new requirements seems to be causing user issues. So we are relaxing the validation to be consistent with previous releases and because there is not a clear need for the validation.

a58ac55 introduced many network validations for on-prem platforms. We want to relax one of those, the check that Ingress & API VIPs are in the machinenetwork because the check prevents using the TUI survey to generate the install config and this (mismatched) configuration has been allowed in all of OpenShift 4 without issue. Fixes OCPBUGS-7015

openshift-ci-robot · 2023-04-20T20:36:14Z

@patrickdillon: This pull request references Jira Issue OCPBUGS-12202, which is invalid:

expected Jira Issue OCPBUGS-12202 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual backport of #6915 and #6967

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-20T20:36:19Z

@patrickdillon: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-12202: Relax vsphere, nutanix VIP validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2023-04-20T20:38:28Z

/jira refresh

openshift-ci-robot · 2023-04-20T20:38:31Z

@patrickdillon: This pull request references Jira Issue OCPBUGS-12202, which is invalid:

expected dependent Jira Issue OCPBUGS-11950 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2023-04-24T14:11:57Z

/label backport-risk-assessed

patrickdillon · 2023-04-24T14:27:15Z

/skip

rvanderp3 · 2023-04-24T18:03:41Z

/lgtm

jhixson74 · 2023-04-24T18:56:16Z

/lgtm
/approve

openshift-ci · 2023-04-24T18:57:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jhixson74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

WenXinWei · 2023-04-25T01:09:27Z

/lgtm

gpei · 2023-04-25T04:46:39Z

/label cherry-pick-approved

patrickdillon · 2023-04-28T19:06:03Z

/label bugzilla/valid-bug

openshift-ci · 2023-04-28T19:06:25Z

@patrickdillon: Can not set label bugzilla/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

Details

In response to this:

/label bugzilla/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2023-04-28T19:08:12Z

/jira refresh

openshift-ci-robot · 2023-04-28T19:08:15Z

@sdodson: This pull request references Jira Issue OCPBUGS-12202, which is invalid:

expected dependent Jira Issue OCPBUGS-11950 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2023-05-18T15:40:15Z

/jira refresh

openshift-ci-robot · 2023-05-18T15:40:20Z

@patrickdillon: This pull request references Jira Issue OCPBUGS-12202, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-11950 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-11950 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z
bug has dependents

Requesting review from QA contact:
/cc @WenXinWei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-05-18T15:49:25Z

/retest-required

Remaining retests: 0 against base HEAD 8864eb7 and 2 for PR HEAD 218f0d9 in total

WenXinWei · 2023-05-22T01:30:50Z

/label qe-approved

openshift-ci-robot · 2023-05-24T15:24:50Z

/retest-required

Remaining retests: 0 against base HEAD c491755 and 1 for PR HEAD 218f0d9 in total

openshift-ci · 2023-05-25T00:42:24Z

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-nutanix-ovn	`218f0d9`	link	false	`/test e2e-nutanix-ovn`
ci/prow/okd-scos-e2e-aws-upgrade	`218f0d9`	link	false	`/test okd-scos-e2e-aws-upgrade`
ci/prow/e2e-aws-ovn-disruptive	`218f0d9`	link	false	`/test e2e-aws-ovn-disruptive`
ci/prow/okd-e2e-aws-ovn-upgrade	`218f0d9`	link	false	`/test okd-e2e-aws-ovn-upgrade`
ci/prow/okd-e2e-aws-ovn	`218f0d9`	link	false	`/test okd-e2e-aws-ovn`
ci/prow/e2e-aws-ovn-upgrade	`218f0d9`	link	false	`/test e2e-aws-ovn-upgrade`
ci/prow/e2e-crc	`218f0d9`	link	false	`/test e2e-crc`
ci/prow/e2e-aws-ovn-workers-rhel8	`218f0d9`	link	false	`/test e2e-aws-ovn-workers-rhel8`
ci/prow/e2e-nutanix-sdn	`218f0d9`	link	false	`/test e2e-nutanix-sdn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-05-25T05:13:14Z

/retest-required

Remaining retests: 0 against base HEAD 473de09 and 0 for PR HEAD 218f0d9 in total

openshift-ci-robot · 2023-05-25T10:23:49Z

@patrickdillon: Jira Issue OCPBUGS-12202: All pull requests linked via external trackers have merged:

openshift/installer#7116

Jira Issue OCPBUGS-12202 has been moved to the MODIFIED state.

Details

In response to this:

Manual backport of #6915 and #6967

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-05-26T12:28:13Z

Fix included in accepted release 4.12.0-0.nightly-2023-05-26-023053

patrickdillon added 2 commits April 20, 2023 16:29

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 20, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 20, 2023

openshift-ci bot requested review from andfasano and rvanderp3 April 20, 2023 20:37

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 24, 2023

openshift-ci bot assigned rvanderp3 Apr 24, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2023

openshift-ci bot assigned jhixson74 Apr 24, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023

openshift-ci bot assigned WenXinWei Apr 25, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 25, 2023

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 18, 2023

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 18, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 18, 2023

openshift-ci bot requested a review from WenXinWei May 18, 2023 15:40

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 22, 2023

openshift-merge-robot merged commit f1065bd into openshift:release-4.12 May 25, 2023

OCPBUGS-12202: Relax vsphere, nutanix VIP validation #7116

OCPBUGS-12202: Relax vsphere, nutanix VIP validation #7116

Uh oh!

Conversation

patrickdillon commented Apr 20, 2023

Uh oh!

openshift-ci-robot commented Apr 20, 2023

Uh oh!

openshift-ci bot commented Apr 20, 2023

Uh oh!

patrickdillon commented Apr 20, 2023

Uh oh!

openshift-ci-robot commented Apr 20, 2023

Uh oh!

patrickdillon commented Apr 24, 2023

Uh oh!

patrickdillon commented Apr 24, 2023

Uh oh!

rvanderp3 commented Apr 24, 2023

Uh oh!

jhixson74 commented Apr 24, 2023

Uh oh!

openshift-ci bot commented Apr 24, 2023

Uh oh!

WenXinWei commented Apr 25, 2023

Uh oh!

gpei commented Apr 25, 2023

Uh oh!

patrickdillon commented Apr 28, 2023

Uh oh!

openshift-ci bot commented Apr 28, 2023

Uh oh!

sdodson commented Apr 28, 2023

Uh oh!

openshift-ci-robot commented Apr 28, 2023

Uh oh!

patrickdillon commented May 18, 2023

Uh oh!

openshift-ci-robot commented May 18, 2023

Uh oh!

openshift-ci-robot commented May 18, 2023

Uh oh!

WenXinWei commented May 22, 2023

Uh oh!

openshift-ci-robot commented May 24, 2023

Uh oh!

openshift-ci bot commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented May 25, 2023

Uh oh!

openshift-ci-robot commented May 25, 2023

Uh oh!

openshift-merge-robot commented May 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

openshift-ci bot commented May 25, 2023 •

edited

Loading