OCPBUGS-7015: Relax MachineCIDR check for vSphere, Nutanix

[patrickdillon]

a58ac55 introduced many network validations for on-prem platforms. We want to relax one of those, the check that Ingress & API VIPs are in the machinenetwork because the check prevents using the TUI survey to generate the install config and this (mismatched) configuration has been allowed in all of OpenShift 4 without issue.

Fixes OCPBUGS-7015

/cc creydr jcpowermac sadasu cybertron rvanderp3

[patrickdillon]

/retitle OCPBUGS-7015: Relax MachineCIDR check for vSphere, Nutanix

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-7015, which is invalid:

• expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

a58ac55 introduced many network validations for on-prem platforms. We want to relax one of those, the check that Ingress & API VIPs are in the machinenetwork because the check prevents using the TUI survey to generate the install config and this (mismatched) configuration has been allowed in all of OpenShift 4 without issue.

Fixes OCPBUGS-7015

/cc creydr jcpowermac sadasu cybertron rvanderp3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[patrickdillon]

/jira refresh

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-7015, which is invalid:

• expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[patrickdillon]

/jira refresh

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-7015, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @WenXinWei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[patrickdillon]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@patrickdillon: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cybertron]

/lgtm

[r4f4]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [r4f4]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 664311c and 2 for PR HEAD 0504c55 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c5e3266 and 1 for PR HEAD 0504c55 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 56e85be and 0 for PR HEAD 0504c55 in total

[openshift-ci]

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade	0504c55	link	false	/test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-workers-rhel8	0504c55	link	false	/test e2e-aws-ovn-workers-rhel8
ci/prow/okd-e2e-aws-ovn	0504c55	link	false	/test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn	0504c55	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-upgrade	0504c55	link	false	/test okd-scos-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@patrickdillon: All pull requests linked via external trackers have merged:

• openshift/installer#6915

Jira Issue OCPBUGS-7015 has been moved to the MODIFIED state.

Details

In response to this:

a58ac55 introduced many network validations for on-prem platforms. We want to relax one of those, the check that Ingress & API VIPs are in the machinenetwork because the check prevents using the TUI survey to generate the install config and this (mismatched) configuration has been allowed in all of OpenShift 4 without issue.

Fixes OCPBUGS-7015

/cc creydr jcpowermac sadasu cybertron rvanderp3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@patrickdillon: #6915 failed to apply on top of branch "release-4.12":

Applying: Relax MachineCIDR check for vSphere, Nutanix
Using index info to reconstruct a base tree...
M	pkg/asset/agent/installconfig_test.go
M	pkg/types/validation/installconfig.go
M	pkg/types/validation/installconfig_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/types/validation/installconfig_test.go
Auto-merging pkg/types/validation/installconfig.go
Auto-merging pkg/asset/agent/installconfig_test.go
CONFLICT (content): Merge conflict in pkg/asset/agent/installconfig_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Relax MachineCIDR check for vSphere, Nutanix
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mkowalski]

/revert