Skip to content

[release-4.13] OCPBUGS-11950: vsphere, nutanix survey: relax vip in machine cidr #7107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Apr 20, 2023
Merged

[release-4.13] OCPBUGS-11950: vsphere, nutanix survey: relax vip in machine cidr #7107

openshift-ci merged 1 commit into from
Apr 20, 2023

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 18, 2023

This is an automated cherry-pick of #6967

/assign patrickdillon

@patrickdillon
vsphere, nutanix survey: relax vip in machine cidr
70b8e2c 
This commit removes validation to ensure the ingress and API vips
are in the default machine network cidr. This validation was added
to all on-prem platforms. Installs have worked without this validation
since the release of openshift 4 and the new requirements seems to
be causing user issues. So we are relaxing the validation to be
consistent with previous releases and because there is not a clear need
for the validation.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-7015 has been cloned as Jira Issue OCPBUGS-11950. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-11950: vsphere, nutanix survey: relax vip in machine cidr

Details

In response to this:

This is an automated cherry-pick of #6967

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-7015: vsphere, nutanix survey: relax vip in machine cidr [release-4.13] OCPBUGS-11950: vsphere, nutanix survey: relax vip in machine cidr Apr 18, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 18, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-11950, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-7015 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-7015 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #6967

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gpei April 18, 2023 20:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

[release-4.13] OCPBUGS-11950: vsphere, nutanix survey: relax vip in machine cidr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from barbacbd and rvanderp3 April 18, 2023 20:05
@patrickdillon
Copy link
Contributor

patrickdillon commented Apr 18, 2023

/label backport-risk-assessed
/approve
/lgtm

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Apr 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
@gpei
Copy link
Contributor

gpei commented Apr 19, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 19, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 19, 2023

/retest-required

Remaining retests: 0 against base HEAD a8cdbf0 and 2 for PR HEAD 70b8e2c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2023 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-workers-rhel8 70b8e2c link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-aws-ovn-disruptive 70b8e2c link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-nutanix-sdn 70b8e2c link false /test e2e-nutanix-sdn
ci/prow/e2e-aws-ovn-upgrade 70b8e2c link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-zones 70b8e2c link false /test e2e-vsphere-zones
ci/prow/e2e-nutanix-ovn 70b8e2c link false /test e2e-nutanix-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 20, 2023

/retest-required

Remaining retests: 0 against base HEAD b8b4970 and 1 for PR HEAD 70b8e2c in total

@patrickdillon
Copy link
Contributor

patrickdillon commented Apr 20, 2023

/skip

@openshift-ci openshift-ci bot merged commit 4fd6714 into openshift:release-4.13 Apr 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 20, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-11950: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11950 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #6967

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Apr 28, 2023

Fix included in accepted release 4.13.0-0.nightly-2023-04-27-232707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpei gpei Awaiting requested review from gpei

@barbacbd barbacbd Awaiting requested review from barbacbd

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @patrickdillon @gpei @openshift-merge-robot