Add IBM Power VS: manifest assets#5610
Add IBM Power VS: manifest assets#5610openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
clnperez
changed the title
kirankt
left a comment
kirankt
left a comment
There was a problem hiding this comment.
Before you commit changes to the PR, please make sure that you've run the linters and tests. This will help cut down failed CI tests.
https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#contribution-flow
|
@kirankt yep, thanks.i thought we had all those covered in our fork where we've been doing dev for the past several months but it looks like we missed some. will address those for sure |
|
I think we'll need to get at least #5609 merged before this will build and really run any tests |
clnperez
force-pushed
the
new-manifest-assets
branch
from
8d9e460 to
eaffb80
Compare
clnperez
force-pushed
the
new-manifest-assets
branch
from
eaffb80 to
22ee09c
Compare
|
/retest-required |
|
looks like this also depends on #5612 |
clnperez
force-pushed
the
new-manifest-assets
branch
from
22ee09c to
5961a1e
Compare
|
added cloud-config while we wait for the others, but this does now require #5700 |
clnperez
force-pushed
the
new-manifest-assets
branch
2 times, most recently
from
3c3719e to
2512ee1
Compare
|
/retest |
1 similar comment
|
/retest |
clnperez
force-pushed
the
new-manifest-assets
branch
from
2512ee1 to
b3ef097
Compare
|
i think this one is good to go now @patrickdillon @Prashanth684 @rna-afk |
|
/retest-required and maybe those two aws jobs will pass 🤞🏻 |
For more background on IPI on Power VS, refer to the enhancement proposal here: openshift/enhancements#736 Older discussions on some of the code here can be found in openshift#5224 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
clnperez
force-pushed
the
new-manifest-assets
branch
from
b3ef097 to
2d48e99
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@clnperez: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
8 participants
For more background on IPI on Power VS, refer to the enhancement
proposal here: openshift/enhancements#736
Older discussions on some of the code here can be found in
#5224
Signed-off-by: Christy Norman christy@linux.vnet.ibm.com