Skip to content

Add VPCRegionForPowerVSRegion function#5700

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
hamzy:types-create-cloudprovider
Mar 12, 2022
Merged

Add VPCRegionForPowerVSRegion function#5700
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
hamzy:types-create-cloudprovider

Conversation

@hamzy
Copy link
Copy Markdown
Contributor

@hamzy hamzy commented Mar 11, 2022

This function will be used to create a CloudProvider config for
Power VS among other potential uses.

This function will be used to create a CloudProvider config for
Power VS among other potential uses.
@clnperez
Copy link
Copy Markdown
Contributor

@patrickdillon another Power VS PR. Can we get this one merged before the manifest assets one (#5610)? I'm going to make a small change to that one but need this first. Trying to cut down on the number of PRs since CI is such a time-consuming gate for these.

@clnperez
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022
@patrickdillon
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2022
@patrickdillon
Copy link
Copy Markdown
Contributor

since CI is such a time-consuming gate for these.

Agree. I'm really hoping we can devote some time to improving this experience ASAP.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 12, 2022

@hamzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws b08cafb link false /test okd-e2e-aws
ci/prow/e2e-azure-upi b08cafb link false /test e2e-azure-upi
ci/prow/e2e-ibmcloud b08cafb link false /test e2e-ibmcloud
ci/prow/e2e-openstack b08cafb link false /test e2e-openstack
ci/prow/e2e-aws-workers-rhel8 b08cafb link false /test e2e-aws-workers-rhel8
ci/prow/okd-e2e-aws-upgrade b08cafb link false /test okd-e2e-aws-upgrade
ci/prow/e2e-crc b08cafb link false /test e2e-crc
ci/prow/e2e-aws-single-node b08cafb link false /test e2e-aws-single-node
ci/prow/e2e-metal-ipi-ovn-ipv6 b08cafb link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-single-node-live-iso b08cafb link false /test e2e-metal-single-node-live-iso

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e77fbc5 into openshift:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants