Skip to content

Power VS: Add CIS CRN to Infrastructure manifest#5269

Closed
mjturek wants to merge 19 commits intoopenshift:masterfrom
mjturek:add-crn-to-infra
Closed

Power VS: Add CIS CRN to Infrastructure manifest#5269
mjturek wants to merge 19 commits intoopenshift:masterfrom
mjturek:add-crn-to-infra

Conversation

@mjturek
Copy link
Copy Markdown
Contributor

@mjturek mjturek commented Oct 6, 2021

Add the CIS CRN to infrastructure manifest for Power VS provider. This is required for the cluster-ingress-operator. This PR does what #5182 does for IBM Cloud, but for Power VS.

Depends on #5224

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 6, 2021

Hi @mjturek. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 6, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wking after the PR has been reviewed.
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 6, 2021
@openshift-ci openshift-ci Bot requested review from jhixson74 and rna-afk October 6, 2021 17:43
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2021
clnperez and others added 19 commits November 8, 2021 17:25
@clnperez
Power VS Support
6744924 
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@clnperez
Merge branch 'openshift:master' into add-ipi
42e7ea1
@clnperez
Merge branch 'openshift:master' into add-ipi
9218e99
@clnperez
terraform changes for Power VS
a695cd9 
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@clnperez
Power VS Support: powervs types
cc814b4 
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@clnperez
Power VS Support: assets only
b27f555 
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@clnperez
install config simplification
e77452a 
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@clnperez
go.sum in lieu of complete vendoring
afe67d0 
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@clnperez
Merge pull request openshift-powervs#65 from clnperez/fork-migration
c83f252 
updates by way of the PRs that were intended to go upstream. these have some changes including code fixes, linting, test updates, and then a PR that addressed some of the comments from Prashanth on the terraform PR upstream.
@clnperez
Merge branch 'openshift:master' into add-ipi
f0c7674
@clnperez
fixing image bug
cf684f5 
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@clnperez
Merge pull request openshift-powervs#70 from clnperez/fix-machine-img
f32927f 
fixing image bug
@clnperez
Merge remote-tracking branch 'upstream/master' into add-ipi-mc
a4c3614
@clnperez
Merge pull request openshift-powervs#72 from clnperez/add-ipi-mc
3a2b0e3 
manual upstream merge
@23TNC
Session changes (openshift-powervs#69)
ab7018f 
Writing session variables to .powervs in home directory so they are persistant between GetSession calls
@mjturek
Import image via COS (openshift-powervs#68)
160b690
@miyamotoh
Adding plumbing to expose bootstrap node's port 22 (openshift-powervs#73
4c32f26 
)

Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>
@clnperez
Merge branch 'openshift:master' into add-ipi
4f753f9
Add CIS CRN to Infrastructure manifest
1f6e109 
Add the CIS CRN to infrastructure manifest for Power VS provider.
This is required for the cluster-ingress-operator. This PR does
what openshift#5182 does for IBM Cloud, but for Power VS.
@openshift-ci openshift-ci Bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Nov 16, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 1, 2021

@mjturek: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2021
@clnperez
Copy link
Copy Markdown
Contributor

clnperez commented Jan 7, 2022

@mjturek can you close this? i'm closing my old oudated ones.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 26, 2022

@mjturek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6-required a4dca095511e2430d23ae9ed1c8608a7b0cc9f26 link true /test e2e-metal-ipi-ovn-ipv6-required
ci/prow/e2e-metal-ipi a4dca095511e2430d23ae9ed1c8608a7b0cc9f26 link false /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-ovn-dualstack a4dca095511e2430d23ae9ed1c8608a7b0cc9f26 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-virtualmedia a4dca095511e2430d23ae9ed1c8608a7b0cc9f26 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-openstack-upi a4dca095511e2430d23ae9ed1c8608a7b0cc9f26 link false /test e2e-openstack-upi
ci/prow/okd-unit 1f6e109 link true /test okd-unit
ci/prow/okd-verify-codegen 1f6e109 link true /test okd-verify-codegen
ci/prow/tf-fmt 1f6e109 link false /test tf-fmt
ci/prow/verify-codegen 1f6e109 link true /test verify-codegen
ci/prow/okd-images 1f6e109 link true /test okd-images
ci/prow/okd-e2e-aws-upgrade 1f6e109 link false /test okd-e2e-aws-upgrade
ci/prow/okd-e2e-aws 1f6e109 link false /test okd-e2e-aws
ci/prow/yaml-lint 1f6e109 link true /test yaml-lint
ci/prow/e2e-libvirt 1f6e109 link false /test e2e-libvirt
ci/prow/e2e-metal-single-node-live-iso 1f6e109 link false /test e2e-metal-single-node-live-iso
ci/prow/govet 1f6e109 link true /test govet
ci/prow/unit 1f6e109 link true /test unit
ci/prow/golint 1f6e109 link true /test golint
ci/prow/e2e-metal-ipi-ovn-ipv6 1f6e109 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-workers-rhel8 1f6e109 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-ovirt 1f6e109 link false /test e2e-ovirt
ci/prow/e2e-openstack-kuryr 1f6e109 link false /test e2e-openstack-kuryr
ci/prow/verify-vendor 1f6e109 link true /test verify-vendor
ci/prow/e2e-crc 1f6e109 link false /test e2e-crc
ci/prow/e2e-openstack 1f6e109 link false /test e2e-openstack
ci/prow/e2e-aws-workers-rhel7 1f6e109 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-fips 1f6e109 link false /test e2e-aws-fips
ci/prow/e2e-aws-single-node 1f6e109 link false /test e2e-aws-single-node
ci/prow/images 1f6e109 link true /test images
ci/prow/e2e-aws-upgrade 1f6e109 link true /test e2e-aws-upgrade
ci/prow/e2e-aws 1f6e109 link true /test e2e-aws
ci/prow/openstack-manifests 1f6e109 link true /test openstack-manifests
ci/prow/e2e-alibaba 1f6e109 link true /test e2e-alibaba

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mjturek
Copy link
Copy Markdown
Contributor Author

mjturek commented Feb 15, 2022 •
edited
Loading

This is no longer needed as it is integrated into #5610

@mjturek mjturek closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

No one assigned

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mjturek @clnperez @23TNC @miyamotoh