Skip to content

Create CloudProvider config for Power VS#126

Merged
clnperez merged 1 commit intoopenshift-powervs:add-ipifrom
HamzyOrg:20220309-cloudprovider-config
Mar 15, 2022
Merged

Create CloudProvider config for Power VS#126
clnperez merged 1 commit intoopenshift-powervs:add-ipifrom
HamzyOrg:20220309-cloudprovider-config

Conversation

@hamzy
Copy link
Copy Markdown

@hamzy hamzy commented Mar 9, 2022

Since we are using the ibmcloud provider in the CCCMO, we need to create a cloud provider config in installer.

@hamzy
Copy link
Copy Markdown
Author

hamzy commented Mar 9, 2022

@Karthik-K-N What do you think?

Comment thread pkg/types/powervs/powervs_regions.go Outdated
Comment thread pkg/types/powervs/powervs_regions.go Outdated
Comment thread pkg/types/powervs/powervs_regions.go Outdated
@Karthik-K-N
Copy link
Copy Markdown

@hamzy Few minor suggestions apart from it its good to merge

Also a headsup we are working on https://issues.redhat.com/browse/MULTIARCH-2332 , Once this is completed we may need to add few more parameters to cloud conf.

@clnperez
Copy link
Copy Markdown

i'm going to pull this (with Karthik's comments) in to my upstream manifests PR so we'll be able to move a little more quickly there.

@clnperez
Copy link
Copy Markdown

just kidding. it also modifies somthing from /types. @hamzy can you submit an upstream PR with just the types change, and hopefully we can get it merged quickly? then either i get this into the existing manifests PR, or, you can submit it as an addon if that one merges before the your (now-hypothetical) upstream types ones.

@clnperez
Copy link
Copy Markdown

@Karthik-K-N any idea on a timeline for https://issues.redhat.com/browse/MULTIARCH-2332 ? A couple of days, or, weeks? I know that process took a while for another repo.

@hamzy
Copy link
Copy Markdown
Author

hamzy commented Mar 11, 2022

openshift#5700

@clnperez
Copy link
Copy Markdown

i added the manifest bits to openshift#5610

@hamzy hamzy closed this Mar 11, 2022
@clnperez
Copy link
Copy Markdown

@hamzy i'd still like to have this in our fork. that PR probably won't get merged today.

@hamzy
Copy link
Copy Markdown
Author

hamzy commented Mar 12, 2022

I'm confused what add-ipi is then because openshift#5700 and openshift#5610 conflict with this one.

@hamzy hamzy reopened this Mar 12, 2022
@hamzy hamzy force-pushed the 20220309-cloudprovider-config branch from 552b00e to b9fe316 Compare March 12, 2022 14:16
@clnperez
Copy link
Copy Markdown

how do they conflict? they shouldn't so hopefully i didn't mess something up

Since we are using the ibmcloud provider in the CCCMO, we need to create a cloud provider config in installer.
@hamzy hamzy force-pushed the 20220309-cloudprovider-config branch from b9fe316 to 1447f0d Compare March 15, 2022 19:04
@clnperez clnperez merged commit 9dcda6d into openshift-powervs:add-ipi Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants