manual upstream merge#72
Merged
clnperez merged 18 commits intoopenshift-powervs:add-ipifrom Nov 11, 2021
Merged
Conversation
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
This PR enables thin provisioning via the importing process of the RHCOS ova. Terraform will then clone the virtual machine based on the existing template disk type. This adds an additional option in the vsphere platform struct `Thin`.
Correct spelling to improve the readability of the documentation
The logic for generating baremetal manifests and Terraform variables now takes into account the host role tag properly, if defined. This allows to define master/worker hosts in any order. To remain backward compatible, if an host does not have any role defined (or supported value), it's considered eligible for the ControlPlane or Compute respectively, based on the configured requirements. The validation rule has been enhanced to verify that the correct number of hosts have been configured.
…s without a role will be used either for ControlPlane or Compute respectively if required.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
vSphere IPI: Enable thin provisioning via the OVA import
openstack: Add stephenfin to owners
…order Bug 2003113: Improve host role management during assets creation
The vsphere vcenter validation in the installer right now is to check if the first character starts with a lowercase alphabet but we should allow digits as well so removing the first character check in validation.
docs: correct spelling in docs
…letion Bug 1965969: aws: Output public zone id correctly when deleting hosted dns records
update Packet UPI for Equinix Metal rename
…name Bug 2021607: Relax vcenter hostname check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes merge conflict with openstack reviewers in OWNERS_ALIASES