Skip to content

Session changes#69

Merged
clnperez merged 6 commits intoopenshift-powervs:add-ipifrom
23TNC:session-stuff
Nov 11, 2021
Merged

Session changes#69
clnperez merged 6 commits intoopenshift-powervs:add-ipifrom
23TNC:session-stuff

Conversation

@23TNC
Copy link
Copy Markdown

@23TNC 23TNC commented Nov 9, 2021

Writing session variables to .powervs in home directory so they are persistant between GetSession calls

Signed-off-by: wolf cory.klokman@ibm.com

Writing session variables to .powervs in home directory so they are persistant between GetSession calls

Signed-off-by: wolf <cory.klokman@ibm.com>
Copy link
Copy Markdown

@clnperez clnperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion

Comment thread pkg/asset/installconfig/powervs/session.go Outdated
Signed-off-by: wolf <cory.klokman@ibm.com>
Comment thread pkg/asset/installconfig/powervs/session.go Outdated
Comment thread pkg/asset/installconfig/powervs/session.go Outdated
Signed-off-by: wolf <cory.klokman@ibm.com>
Signed-off-by: wolf <cory.klokman@ibm.com>
Comment thread pkg/asset/installconfig/powervs/session.go
Comment thread pkg/asset/installconfig/powervs/session.go Outdated
Comment thread pkg/asset/installconfig/powervs/session.go Outdated
Comment thread pkg/asset/installconfig/powervs/session.go Outdated
Comment thread pkg/asset/installconfig/powervs/session.go Outdated
Comment thread pkg/asset/installconfig/powervs/session.go
Signed-off-by: wolf <cory.klokman@ibm.com>
Signed-off-by: wolf <cory.klokman@ibm.com>
@clnperez clnperez merged commit ab7018f into openshift-powervs:add-ipi Nov 11, 2021
mjturek pushed a commit to mjturek/installer that referenced this pull request Feb 25, 2022
Writing session variables to .powervs in home directory so they are persistant between GetSession calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants