Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Apr 2, 2019

/hold

Just like #1464 and similar, I'm putting this up so folks can take a look before I drop a tag (I'll wait until #1519 gets a /lgtm).

@smarterclayton pushed registry.svc.ci.openshift.org/ocp/release:4.0.0-0.nightly-2019-04-02-081046 to quay.io/openshift-release-dev/ocp-release:4.0.0-0.9.

wking added 3 commits April 2, 2019 10:09
Through 58a2767 (Merge pull request openshift#1497 from
vrutkovs/upi-multistage-cli, 2019-03-29).
Catching up with c734361 (Remove cluster-api object as this is not
needed anymore, 2019-03-22, openshift#1449), 1408d8a (*: use
kube-etcd-cert-signer release image, 2019-03-27, openshift#1477), and possibly
others.  Generated with:

  $ openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg

using:

  $ dot -V
  dot - graphviz version 2.30.1 (20170916.1124)
Clayton pushed
registry.svc.ci.openshift.org/ocp/release:4.0.0-0.nightly-2019-04-02-081046
to quay.io/openshift-release-dev/ocp-release:4.0.0-0.9.

Renaming OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE gets us CI testing
of the pinned release despite openshift/release@60007df2 (Use
RELEASE_IMAGE_LATEST for CVO payload, 2018-10-03,
openshift/release#1793).

I'd initially expected to export the pinning environment variables in
release.sh, but I've put them in build.sh here because our continuous
integration tests use build.sh directly and don't go through
release.sh.

The release-image change-log was generated using the generator from
[1] and:

  $ oc adm release info --changelog ~/.local/lib/go/src --changes-from quay.io/openshift-release-dev/ocp-release:4.0.0-0.8 quay.io/openshift-release-dev/ocp-release:4.0.0-0.9

[1]: openshift/origin#22030
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2019
@abhinavdahiya
Copy link
Contributor

general concern around repos moving together..
#1519 (comment)

cc @smarterclayton @wking

@openshift-ci-robot
Copy link
Contributor

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws ece93f5 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Apr 2, 2019

This is out as 0.16.0 now. But pinning was broken (#1521), so folks should use 0.16.1 instead.

@wking wking closed this Apr 2, 2019
@wking wking deleted the version-0.16.0-pins branch April 2, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants