*: use kube-etcd-cert-signer release image #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/hold
hexfusion
force-pushed
the
metric-signer
branch
from
7607333 to
1e6e4ce
Compare
Contributor
Author
|
/test e2e-aws |
Contributor
Author
|
Dependency openshift/cluster-bootstrap#22 PR has merged /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm /refresh |
Contributor
|
/hold wouldn't the etcd metric flags require openshift/kubecsr#6 to merge ? |
openshift-ci-robot
added
do-not-merge/hold
hexfusion
force-pushed
the
metric-signer
branch
from
1e6e4ce to
8ba3b33
Compare
Contributor
Author
correct, removed. |
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
- For consistency rename etcd-metrics to etcd-metric - Update kube-etcd-cert-signer image to pull from release Signed-off-by: Sam Batschelet <[email protected]>
hexfusion
force-pushed
the
metric-signer
branch
from
8ba3b33 to
1408d8a
Compare
hexfusion
changed the title
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, hexfusion The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Apr 2, 2019
Catching up with c734361 (Remove cluster-api object as this is not needed anymore, 2019-03-22, openshift#1449), 1408d8a (*: use kube-etcd-cert-signer release image, 2019-03-27, openshift#1477), and possibly others. Generated with: $ openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg using: $ dot -V dot - graphviz version 2.30.1 (20170916.1124)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on openshift/cluster-bootstrap#22 merged
/hold