hack/pin-release-image: Add a helper for pinning release images #1464
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
Using the new approach provided by a31e12f (release: Allow release image to be directly substituted into binary, 2019-03-15, openshift#1422). For example: $ hack/build.sh $ cp bin/openshift-install bin/openshift-install-orig $ hack/pin-release-image.sh bin/openshift-install quay.io/openshift-release-dev/ocp-release:4.0.0-0.8 $ diff -u <(hexdump -vC bin/openshift-install-orig) <(hexdump -vC bin/openshift-install) --- /dev/fd/63 2019-03-25 22:30:43.534719090 -0700 +++ /dev/fd/62 2019-03-25 22:30:43.534719090 -0700 @@ -4911608,10 +4911608,10 @@ 04af1f70 20 74 68 65 20 73 61 6d 65 20 49 6e 69 74 69 61 | the same Initia| 04af1f80 6c 69 7a 65 72 43 6f 6e 66 69 67 75 72 61 74 69 |lizerConfigurati| 04af1f90 6f 6e 20 69 73 20 70 72 65 73 65 72 76 65 64 2e |on is preserved.| -04af1fa0 00 5f 52 45 4c 45 41 53 45 5f 49 4d 41 47 45 5f |._RELEASE_IMAGE_| -04af1fb0 4c 4f 43 41 54 49 4f 4e 5f 00 58 58 58 58 58 58 |LOCATION_.XXXXXX| -04af1fc0 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 |XXXXXXXXXXXXXXXX| -04af1fd0 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 |XXXXXXXXXXXXXXXX| +04af1fa0 71 75 61 79 2e 69 6f 2f 6f 70 65 6e 73 68 69 66 |quay.io/openshif| +04af1fb0 74 2d 72 65 6c 65 61 73 65 2d 64 65 76 2f 6f 63 |t-release-dev/oc| +04af1fc0 70 2d 72 65 6c 65 61 73 65 3a 34 2e 30 2e 30 2d |p-release:4.0.0-| +04af1fd0 30 2e 38 00 58 58 58 58 58 58 58 58 58 58 58 58 |0.8.XXXXXXXXXXXX| 04af1fe0 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 |XXXXXXXXXXXXXXXX| 04af1ff0 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 |XXXXXXXXXXXXXXXX| 04af2000 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 |XXXXXXXXXXXXXXXX| @@ -4911628,7 +4911628,7 @@ 04af20b0 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 |XXXXXXXXXXXXXXXX| 04af20c0 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 |XXXXXXXXXXXXXXXX| 04af20d0 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 58 |XXXXXXXXXXXXXXXX| -04af20e0 58 58 58 58 58 58 00 53 65 63 72 65 74 4e 61 6d |XXXXXX.SecretNam| +04af20e0 58 58 58 58 58 58 58 53 65 63 72 65 74 4e 61 6d |XXXXXXXSecretNam| 04af20f0 65 20 69 73 20 74 68 65 20 6e 61 6d 65 20 6f 66 |e is the name of| 04af2100 20 74 68 65 20 73 65 63 72 65 74 20 75 73 65 64 | the secret used| 04af2110 20 74 6f 20 74 65 72 6d 69 6e 61 74 65 20 53 53 | to terminate SS|
wking
force-pushed
the
release-pinning-script
branch
from
d7ebd61 to
0b03d3e
Compare
|
All green here, CC @abhinavdahiya, @smarterclayton. There's also a Go version in flight in openshift/origin#22439, but as long as I'm cutting installer releases (maybe not much longer?) having a script version of this is nice. And this can also make it easier for folks who want to tweak the installer to support their disconnected environment so they can hand this out to devs without them having to set |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
It looks like our release pipeline takes care of this and we don't need this very much. closing for now. /close |
|
@abhinavdahiya: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
Using the new approach provided by a31e12f (#1422). For example:
CC @smarterclayton