Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Apr 2, 2019

Through 58a2767 (Merge pull request #1497 from vrutkovs/upi-multistage-cli, 2019-03-29).

The base commit is from:

$ oc image info $(oc adm release info --image-for=installer quay.io/openshift-release-dev/ocp-release:4.0.0-0.9) | grep commit.url
             io.openshift.build.commit.url=https://github.com/openshift/installer/commit/58a27678c02d28693306e1ff5ff8480d7c9fb84c

I've also rebuilt the asset-graph SVG.

wking added 2 commits April 2, 2019 10:09
Through 58a2767 (Merge pull request openshift#1497 from
vrutkovs/upi-multistage-cli, 2019-03-29).
Catching up with c734361 (Remove cluster-api object as this is not
needed anymore, 2019-03-22, openshift#1449), 1408d8a (*: use
kube-etcd-cert-signer release image, 2019-03-27, openshift#1477), and possibly
others.  Generated with:

  $ openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg

using:

  $ dot -V
  dot - graphviz version 2.30.1 (20170916.1124)
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 2, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

It's concerning that,
58a2767 is 4 days old.

while operator like mco which is tightly coupled to the installer is only 1 day old:

$ oc adm release info  quay.io/openshift-release-dev/ocp-release:4.0.0-0.9 --commits | rg machine-config-controller
  machine-config-controller                     https://github.com/openshift/machine-config-operator                       ee4e0643716780def1aadaaf7ef4f67b2f99cd7f
$ git --no-pager show ee4e0643716780def1aadaaf7ef4f67b2f99cd7f
commit ee4e0643716780def1aadaaf7ef4f67b2f99cd7f
Merge: 6d351e1 feca590
Author: OpenShift Merge Robot <[email protected]>
Date:   Mon Apr 1 09:07:15 2019 -0700

    Merge pull request #592 from JAORMX/info-log-level

    ContainerRuntimeConfig: Enable "info" debug level

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Apr 3, 2019

e2e-aws:

Flaky tests:

[Feature:DeploymentConfig] deploymentconfigs with revision history limits [Conformance] should never persist more old deployments than acceptable after being observed by the controller [Suite:openshift/conformance/parallel/minimal]

Failing tests:

[k8s.io] Kubelet when scheduling a busybox Pod with hostAliases should write entries to /etc/hosts [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-storage] In-tree Volumes [Driver: aws] [Testpattern: Dynamic PV (block volmode)] volumeMode should create sc, pod, pv, and pvc, read/write to the pv, and delete all created resources [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-storage] In-tree Volumes [Driver: nfs] [Testpattern: Pre-provisioned PV (block volmode)] volumeMode should fail to create pod by failing to mount volume [Suite:openshift/conformance/parallel] [Suite:k8s]

Those were mitigated by openshift/origin#22454 and openshift/origin#22455 until we get a new machine-os-content with an OSTree built with the new, 1.13 kubelet.

/retest

@wking
Copy link
Member Author

wking commented Apr 3, 2019

e2e-aws:

aws_s3_bucket.ignition: NoSuchBucket: The specified bucket does not exist

/retest

@openshift-merge-robot openshift-merge-robot merged commit ccf533a into openshift:master Apr 3, 2019
@wking wking deleted the version-0.16.0 branch April 3, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants