[release-4.14] OCPBUGS-23558: Let router use svc ips 4.14 by enxebre · Pull Request #3221 · openshift/hypershift

enxebre · 2023-11-22T10:51:25Z

What this PR does / why we need it:
Cherry-picks #3218

It also brings
#3185
#3186
To accommodate conflicts and reduce drift.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

The kas SVC port is an impl detail. Before this change their value was wrongly conflated with the spec.metworking.apiServer.port input. If we ever require the dedicated KAS LB port to be a choice, that would be input in the LB publishing strategy.

openshift-ci-robot · 2023-11-22T10:51:31Z

@enxebre: This pull request references Jira Issue OCPBUGS-23558, which is invalid:

expected the bug to target either version "4.14." or "openshift-4.14.", but it targets "4.15.0" instead
expected Jira Issue OCPBUGS-23558 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:
Cherry-picks #3218

It also brings
#3185
#3186
To accommodate conflicts and reduce drift.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-11-22T10:54:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

enxebre · 2023-11-22T11:09:19Z

/override "Red Hat Trusted App Test / mce-24-snc9n / tektok-runner-enterprise-contract-mce-2.4"

openshift-ci · 2023-11-22T11:11:39Z

@enxebre: Overrode contexts on behalf of enxebre: Red Hat Trusted App Test / mce-24-snc9n / tektok-runner-enterprise-contract-mce-2.4

Details

In response to this:

/override "Red Hat Trusted App Test / mce-24-snc9n / tektok-runner-enterprise-contract-mce-2.4"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre · 2023-11-22T15:24:06Z

openshift/release#45885
/retest

enxebre · 2023-11-22T17:04:43Z

/test e2e-aws

sjenning · 2023-11-22T18:35:25Z

/lgtm

enxebre · 2023-11-23T07:46:09Z

/jira refresh

openshift-ci-robot · 2023-11-23T07:46:13Z

@enxebre: This pull request references Jira Issue OCPBUGS-23558, which is invalid:

expected Jira Issue OCPBUGS-23558 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre · 2023-11-23T07:48:28Z

/jira refresh

openshift-ci-robot · 2023-11-23T07:48:37Z

@enxebre: This pull request references Jira Issue OCPBUGS-23558, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-23466 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-23466 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre · 2023-11-23T07:55:31Z

/override "Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request"

openshift-ci · 2023-11-23T07:55:47Z

@enxebre: Overrode contexts on behalf of enxebre: Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request

Details

In response to this:

/override "Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre · 2023-11-23T10:22:41Z

All test passed though prow complains pod go deleted unexpectedly https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_hypershift/3221/pull-ci-openshift-hypershift-release-4.14-e2e-aws/1727597362857119744

/test e2e-aws

openshift-ci · 2023-11-23T12:20:36Z

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-11-23T12:23:47Z

@enxebre: Jira Issue OCPBUGS-23558: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23558 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:
Cherry-picks #3218

It also brings
#3185
#3186
To accommodate conflicts and reduce drift.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-11-24T02:56:27Z

Fix included in accepted release 4.14.0-0.nightly-2023-11-23-154014

enxebre added 3 commits November 22, 2023 11:27

Consume kas port by name

2551aa9

Let kas SVC port to be hardcoded

c030ab6

The kas SVC port is an impl detail. Before this change their value was wrongly conflated with the spec.metworking.apiServer.port input. If we ever require the dedicated KAS LB port to be a choice, that would be input in the LB publishing strategy.

Let router use svc ips

5e01478

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 22, 2023

openshift-ci Bot added the do-not-merge/needs-area label Nov 22, 2023

openshift-ci Bot requested review from csrwng and hasueki November 22, 2023 10:54

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023

openshift-ci Bot assigned sjenning Nov 22, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023

enxebre mentioned this pull request Nov 22, 2023

[release-4.14] OCPBUGS-29000,OCPBUGS-28984,OCPBUGS-28985,OCPBUGS-28986,OCPBUGS-19956: Support Disconnected HCP #3064

Closed

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 23, 2023

openshift-merge-bot Bot merged commit d585d8b into openshift:release-4.14 Nov 23, 2023

Uh oh!

Conversation

enxebre commented Nov 22, 2023

Uh oh!

openshift-ci-robot commented Nov 22, 2023

Uh oh!

openshift-ci Bot commented Nov 22, 2023

Uh oh!

enxebre commented Nov 22, 2023

Uh oh!

openshift-ci Bot commented Nov 22, 2023

Uh oh!

enxebre commented Nov 22, 2023

Uh oh!

enxebre commented Nov 22, 2023

Uh oh!

sjenning commented Nov 22, 2023

Uh oh!

enxebre commented Nov 23, 2023

Uh oh!

openshift-ci-robot commented Nov 23, 2023

Uh oh!

enxebre commented Nov 23, 2023

Uh oh!

openshift-ci-robot commented Nov 23, 2023

Uh oh!

enxebre commented Nov 23, 2023

Uh oh!

openshift-ci Bot commented Nov 23, 2023

Uh oh!

enxebre commented Nov 23, 2023

Uh oh!

openshift-ci Bot commented Nov 23, 2023

Uh oh!

openshift-ci-robot commented Nov 23, 2023

Uh oh!

openshift-merge-robot commented Nov 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants