Bump to installer master branch #228
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XXL
|
/lgtm |
|
/test e2e |
csrwng
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
2 similar comments
|
/retest |
|
/retest |
openshift-ci-robot
added
needs-rebase
csrwng
force-pushed
the
bump_installer
branch
from
c1ba201 to
cde8eb1
Compare
openshift-ci-robot
removed
the
needs-rebase
csrwng
force-pushed
the
bump_installer
branch
from
cde8eb1 to
91c8feb
Compare
|
/lgtm |
|
/retest |
|
/test e2e |
csrwng
force-pushed
the
bump_installer
branch
from
0abf822 to
297ab27
Compare
csrwng
force-pushed
the
bump_installer
branch
from
297ab27 to
701b81d
Compare
|
/test e2e |
|
/retest |
Support installer InfraID.
|
/lgtm |
|
LGTM on new changes from a PR by myself has to be cheating somehow. |
|
@csrwng: The following test failed for commit df4a5ff, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
We have manually completed an e2e test. /override ci/prow/e2e |
|
@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When we pivoted to v1beta3 in ccdc32e (installconfig: separate control plane and compute machine pools, 2019-01-29, openshift#1157), we dropped support for the old 'machines' JSON property. Instead of silently ignoring that property in v1beta2 configs, error out to avoid surprising users later when they notice us not picking up their machines configuration. Or internal consumers pivoted to v1beta3 in openshift/release@e1d729c6 (Modify install-config.yaml to use controlPlane and compute instead of machines, 2019-02-05, openshift/release#2787) and openshift/hive@3eda6d12 (Bump to installer master branch, 2019-02-21, openshift/hive#228).
4 participants
Includes fix for uninstall from installer master repo
Fixes up remotemachineset controller to work with machine-api instead of cluster-api