Skip to content

Short name and custom printer columns for the ClusterDeployment CRD #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 25, 2019
Merged

Short name and custom printer columns for the ClusterDeployment CRD #230

openshift-merge-robot merged 1 commit into from
Feb 25, 2019

Conversation

@fabianofranz
Copy link
Member

@fabianofranz fabianofranz commented Feb 22, 2019 •
edited
Loading

Adds the cd short name to the ClusterDeployment CRD so that we can do kubectl get cd.
Adds baseDomain and status.installed as custom printer columns so that the printer output looks like

$ kubectl get cd
NAME     BASEDOMAIN                                INSTALLED   AGE
ffranz   ffranz-cluster-deployment.openshift.com   false       4m7s

@csrwng @dgoodwin makes sense?

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2019
@fabianofranz fabianofranz force-pushed the clusterdeployment-crd-names branch 2 times, most recently from df5012b to f92424a Compare February 22, 2019 21:14
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2019
@fabianofranz
Copy link
Member Author

fabianofranz commented Feb 22, 2019

/test e2e

@csrwng
Copy link
Contributor

csrwng commented Feb 22, 2019 •
edited
Loading

@fabianofranz it won’t pass e2e until #228 merges. I was hoping it would have merged by now. But for whatever reason it just says “in merge pool”

@fabianofranz
Copy link
Member Author

fabianofranz commented Feb 23, 2019

/test e2e

@csrwng
Copy link
Contributor

csrwng commented Feb 23, 2019

/retest

@csrwng
Copy link
Contributor

csrwng commented Feb 24, 2019

@fabianofranz looks like you need to rebase

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2019
@fabianofranz fabianofranz force-pushed the clusterdeployment-crd-names branch from f92424a to e7059ae Compare February 25, 2019 02:30
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2019
@fabianofranz
Copy link
Member Author

fabianofranz commented Feb 25, 2019

/retest

@csrwng
Copy link
Contributor

csrwng commented Feb 25, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@openshift-merge-robot openshift-merge-robot merged commit 982152d into openshift:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abutcher abutcher Awaiting requested review from abutcher

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@csrwng csrwng

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabianofranz @csrwng @openshift-ci-robot @openshift-merge-robot