Skip to content

Add MachinePool labels and taints. #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 26, 2019
Merged

Add MachinePool labels and taints. #207

openshift-merge-robot merged 1 commit into from
Feb 26, 2019

Conversation

@abutcher
Copy link
Member

@abutcher abutcher commented Feb 4, 2019 •
edited
Loading

No description provided.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2019
@dgoodwin
Copy link
Contributor

dgoodwin commented Feb 5, 2019

LGTM so far, nice progress.

@abutcher abutcher force-pushed the machinepool-labels-taints branch from 6efd991 to e880749 Compare February 13, 2019 20:38
@abutcher abutcher changed the title WIP: Add MachinePool labels and taints. Add MachinePool labels and taints. Feb 13, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2019
@abutcher abutcher changed the title Add MachinePool labels and taints. WIP: Add MachinePool labels and taints. Feb 13, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2019
@abutcher abutcher force-pushed the machinepool-labels-taints branch from e880749 to afb6934 Compare February 14, 2019 19:36
@abutcher abutcher changed the title WIP: Add MachinePool labels and taints. Add MachinePool labels and taints. Feb 14, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2019
@dgoodwin
Copy link
Contributor

dgoodwin commented Feb 15, 2019

/lgtm

Thanks @abutcher

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
@dgoodwin
Copy link
Contributor

dgoodwin commented Feb 15, 2019

/test e2e

@abutcher abutcher force-pushed the machinepool-labels-taints branch from afb6934 to 020dfdc Compare February 15, 2019 15:54
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2019
@abutcher
Copy link
Member Author

abutcher commented Feb 15, 2019

/test unit

@abutcher
Copy link
Member Author

abutcher commented Feb 15, 2019

/test e2e

1 similar comment
@abutcher
Copy link
Member Author

abutcher commented Feb 19, 2019

/test e2e

@dgoodwin
Copy link
Contributor

dgoodwin commented Feb 22, 2019

/retest

@dgoodwin
Copy link
Contributor

dgoodwin commented Feb 22, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@abutcher abutcher force-pushed the machinepool-labels-taints branch from 020dfdc to 3a315bc Compare February 22, 2019 19:40
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2019
@dgoodwin
Copy link
Contributor

dgoodwin commented Feb 22, 2019

/lgtm

Tests won't pass until we get #228 through.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 22, 2019
@abutcher abutcher force-pushed the machinepool-labels-taints branch from 3a315bc to be7cb7f Compare February 25, 2019 19:44
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 25, 2019
@dgoodwin
Copy link
Contributor

dgoodwin commented Feb 25, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@abutcher abutcher force-pushed the machinepool-labels-taints branch from be7cb7f to 1177718 Compare February 25, 2019 19:47
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@dgoodwin
Copy link
Contributor

dgoodwin commented Feb 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2019
@openshift-merge-robot openshift-merge-robot merged commit 688b17a into openshift:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

Assignees

@dgoodwin dgoodwin

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abutcher @dgoodwin @openshift-ci-robot @openshift-merge-robot