[WIP]: use controlPlane and compute in install-config.yaml #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds in install-config.yaml
- replace machines field in install-config.yaml with controlPlane and compute - remove iamRoleName from machine pools in install-config.yaml - replace netopv1.ClusterNetwork with ClusterNetworkEntry in InstallConfig - remove ClusterName from ClusterUninstaller
openshift-ci-robot
added
do-not-merge/work-in-progress
Contributor
Author
|
/hold Requires openshift/installer#1157 |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
There are other changes that we may want to do to the Hive API that are not covered by this PR.
|
openshift-ci-robot
added
the
needs-rebase
|
@staebler: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/close Obsolete by #228. |
|
@staebler: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
machinesfield in install-config.yaml will be replaced withcontrolPlaneandcomputefields. This PR brings in the latest openshift/installer version, which includes those changes.