Skip to content

OSASINFRA-3609: Update legacy/openstack-cinder-csi-driver-operator #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Sep 20, 2024
Merged

OSASINFRA-3609: Update legacy/openstack-cinder-csi-driver-operator #281

openshift-merge-bot merged 2 commits into from
Sep 20, 2024

Conversation

@stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Sep 19, 2024 •
edited
Loading

Some new changes were merged into openstack-cinder-csi since #278 was proposed. Let's pull them in.

@stephenfin
Squashed 'legacy/openstack-cinder-csi-driver-operator/' changes from …
4d31865 
…dcac15afd..5dd336fe0

5dd336fe0 Merge pull request openshift#178 from shiftstack/bump-gophercloud
25f0ca97f Bump Gophercloud to v2

git-subtree-dir: legacy/openstack-cinder-csi-driver-operator
git-subtree-split: 5dd336fe0913d50c93e214e088c5a9da561e8744
@stephenfin
Merge commit '4d318650fcf7f0082e591d6bc9a90b799e419eed' into master
ced5e64
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@stephenfin
Copy link
Contributor Author

stephenfin commented Sep 19, 2024

/cc @gnufied
/cc @eurijon
/uncc @bertinatto
/uncc @dobsonj

@openshift-ci openshift-ci bot requested review from eurijon and gnufied and removed request for bertinatto and dobsonj September 19, 2024 17:05
@gnufied
Copy link
Member

gnufied commented Sep 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@stephenfin
Copy link
Contributor Author

stephenfin commented Sep 19, 2024 •
edited by openshift-ci bot
Loading

/retitle OSASINFRA-3609: Update legacy/openstack-cinder-csi-driver-operator

@openshift-ci openshift-ci bot changed the title Update legacy/openstack-cinder-csi-driver-operator OSASINFRA-3609: Update legacy/openstack-cinder-csi-driver-operator Sep 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3609 which is a valid jira issue.

Details

In response to this:

Some new changes were merged into openstack-cinder-csi since #278 was proposed. Let's pull them in.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin
Copy link
Contributor Author

stephenfin commented Sep 19, 2024

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

@stephenfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi ced5e64 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mandre
mandre reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gnufied
Copy link
Member

gnufied commented Sep 20, 2024

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Sep 20, 2024
@eurijon
Copy link

eurijon commented Sep 20, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3609 which is a valid jira issue.

Details

In response to this:

Some new changes were merged into openstack-cinder-csi since #278 was proposed. Let's pull them in.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 3bb5709 into openshift:master Sep 20, 2024
@stephenfin stephenfin deleted the update-cinder-csi branch September 20, 2024 14:57
@openshift-bot
Copy link

openshift-bot commented Sep 20, 2024

[ART PR BUILD NOTIFIER]

Distgit: azure-file-csi-driver-operator
This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.18.0-202409201540.p0.g3bb5709.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-azure-disk-csi-driver-operator
This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.18.0-202409201540.p0.g3bb5709.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-efs-csi-driver-operator
This PR has been included in build ose-aws-efs-csi-driver-operator-container-v4.18.0-202409201540.p0.g3bb5709.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-smb-csi-driver-operator
This PR has been included in build ose-smb-csi-driver-operator-container-v4.18.0-202409201540.p0.g3bb5709.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-ebs-csi-driver-operator
This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.18.0-202409201540.p0.g3bb5709.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 20, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-openstack-cinder-csi-driver-operator
This PR has been included in build ose-openstack-cinder-csi-driver-operator-container-v4.18.0-202409201910.p0.g3bb5709.assembly.stream.el9.
All builds following this will include this PR.

@stephenfin stephenfin mentioned this pull request Sep 23, 2024
Merged
@stephenfin stephenfin mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eurijon eurijon Awaiting requested review from eurijon

@gnufied gnufied Awaiting requested review from gnufied

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gnufied gnufied

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stephenfin @gnufied @openshift-ci-robot @eurijon @openshift-bot @mandre