Skip to content

OSASINFRA-3618: Reflect changes to Cinder CSI driver operator #57034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Oct 24, 2024
Merged

OSASINFRA-3618: Reflect changes to Cinder CSI driver operator #57034

openshift-merge-bot merged 1 commit into from
Oct 24, 2024

Conversation

@stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Sep 23, 2024 •
edited
Loading

The location of files have changed [1]. Reflect this.

[1] must merge before we can merge this. This PR is merged now.

[1] openshift/csi-operator#275

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

Details

In response to this:

The location of files have changed [1]. Reflect this.

[1] must merge before we can merge this.

[1] openshift/csi-operator#275

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2024
@stephenfin
OSASINFRA-3618: Reflect changes to Cinder CSI driver operator
a2493d1 
The location of files have changed [1]. Reflect this.

[1] openshift/csi-operator#275

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2024
@stephenfin stephenfin marked this pull request as ready for review October 14, 2024 16:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
@stephenfin
Copy link
Contributor Author

stephenfin commented Oct 14, 2024

/cc @mandre
/cc @gnufied

@openshift-ci openshift-ci bot requested review from gnufied and mandre October 14, 2024 16:44
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 14, 2024

[REHEARSALNOTIFIER]
@stephenfin: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-operator-master-e2e-openstack openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-openstack-cinder-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.19-e2e-openstack openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.19-e2e-openstack-cinder-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.18-e2e-openstack openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.18-e2e-openstack-cinder-csi openshift/csi-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 14, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

Details

In response to this:

The location of files have changed [1]. Reflect this.

[1] must merge before we can merge this. This PR is merged now.

[1] openshift/csi-operator#275

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jsafrane and tsmetana October 14, 2024 16:46
@stephenfin stephenfin mentioned this pull request Oct 15, 2024
Merged
mandre
mandre reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2024
@stephenfin
Copy link
Contributor Author

stephenfin commented Oct 15, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 15, 2024

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stephenfin
Copy link
Contributor Author

stephenfin commented Oct 17, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2024

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stephenfin
Copy link
Contributor Author

stephenfin commented Oct 17, 2024

/pj-rehearse pull-ci-openshift-csi-operator-release-4.19-e2e-openstack-cinder-csi

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2024

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mandre
Copy link
Member

mandre commented Oct 17, 2024

I'm pretty sure the failure is caused by the load of jobs hitting the same infra node at the same time, let's try again with just the failing job:
/pj-rehearse pull-ci-openshift-csi-operator-release-4.19-e2e-openstack-cinder-csi

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2024

@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stephenfin
Copy link
Contributor Author

stephenfin commented Oct 17, 2024

@mandre jinx 😉

@MaysaMacedo
Copy link
Contributor

MaysaMacedo commented Oct 17, 2024

/lgtm

@stephenfin
Copy link
Contributor Author

stephenfin commented Oct 17, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2024

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 17, 2024
mandre
mandre reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gnufied
Copy link
Member

gnufied commented Oct 24, 2024

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, mandre, MaysaMacedo, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 52358bb into openshift:master Oct 24, 2024
@openshift-merge-bot openshift-merge-bot bot deleted the OSASINFRA-3618 branch October 24, 2024 16:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ptalgulk01 pushed a commit to ptalgulk01/release that referenced this pull request Oct 29, 2024
@stephenfin
OSASINFRA-3618: Reflect changes to Cinder CSI driver operator (opensh…
66bd9bc 
…ift#57034)

The location of files have changed [1]. Reflect this.

[1] openshift/csi-operator#275

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Oct 31, 2024
@stephenfin @obochan-rh
OSASINFRA-3618: Reflect changes to Cinder CSI driver operator (opensh…
4886d81 
…ift#57034)

The location of files have changed [1]. Reflect this.

[1] openshift/csi-operator#275

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

@tsmetana tsmetana Awaiting requested review from tsmetana

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gnufied gnufied

@mandre mandre

@MaysaMacedo MaysaMacedo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stephenfin @openshift-ci-robot @mandre @MaysaMacedo @gnufied @openshift-merge-robot