Skip to content

Bug 2009454: Change web terminal subscription permissions from get to list#588

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JPinkney:web-terminal-permissions
Oct 1, 2021
Merged

Bug 2009454: Change web terminal subscription permissions from get to list#588
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JPinkney:web-terminal-permissions

Conversation

@JPinkney
Copy link
Copy Markdown
Contributor

@JPinkney JPinkney commented Sep 10, 2021 •
edited
Loading

This PR is in conjunction with: openshift/console#10045

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

@JPinkney
Change web terminal subscription permissions from get to list
84d500a 
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@openshift-ci openshift-ci Bot requested review from jhadvig and spadgett September 10, 2021 17:46
@JPinkney JPinkney mentioned this pull request Sep 10, 2021
Merged
@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2021
jhadvig
jhadvig approved these changes Sep 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for the frontend review of openshift/console#10045

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, JPinkney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@JPinkney
Copy link
Copy Markdown
Contributor Author

JPinkney commented Sep 24, 2021

/retest

This was referenced Sep 24, 2021
Merged
Merged
Merged
Merged
@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Sep 27, 2021

/hold cancel
/retest

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 27, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 27, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Sep 30, 2021

@JPinkney in ordeer to merge your PR you need either
bugzilla/valid-bug label
OR
docs-approved, px-approved, qe-approved labels.

@JPinkney JPinkney changed the title Change web terminal subscription permissions from get to list Bug 2009454: Change web terminal subscription permissions from get to list Sep 30, 2021
@openshift-ci openshift-ci Bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 30, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 30, 2021

@JPinkney: This pull request references Bugzilla bug 2009454, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2009454: Change web terminal subscription permissions from get to list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JPinkney
Copy link
Copy Markdown
Contributor Author

JPinkney commented Sep 30, 2021

@jhadvig I just created the bugzilla and linked it to this PR. Let me know if anything else is needed!

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 1, 2021

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 1, 2021

@openshift-bot: This pull request references Bugzilla bug 2009454, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Oct 1, 2021

/bugzilla refresh

@openshift-ci openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 1, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 1, 2021

@jhadvig: This pull request references Bugzilla bug 2009454, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from sanketpathak October 1, 2021 06:32
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 1, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 1, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 1, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6c08cb7 into openshift:master Oct 1, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 1, 2021

@JPinkney: All pull requests linked via external trackers have merged:

Bugzilla bug 2009454 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2009454: Change web terminal subscription permissions from get to list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christoph-jerolimov
Copy link
Copy Markdown
Member

christoph-jerolimov commented Jan 4, 2022

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 4, 2022

@jerolimov: Bugzilla bug 2009454 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christoph-jerolimov
Copy link
Copy Markdown
Member

christoph-jerolimov commented Jan 4, 2022

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 4, 2022

@jerolimov: Bugzilla bug 2009454 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JPinkney @jhadvig @openshift-bot @christoph-jerolimov @openshift-merge-robot