[release-4.9] Bug 2008142: Change web terminal subscription permissions from get to list by JPinkney · Pull Request #596 · openshift/console-operator

JPinkney · 2021-09-27T12:30:25Z

This PR cherry-picks #588 back to 4.9. Related Console side PR backport for 4.9 is: openshift/console#10135

Signed-off-by: Josh Pinkney joshpinkney@gmail.com
(cherry picked from commit 84d500a)

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> (cherry picked from commit 84d500a)

openshift-ci · 2021-09-27T12:30:29Z

@JPinkney: This pull request references Bugzilla bug 2008142, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead
expected Bugzilla bug 2008142 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

(4.9 Backport) Bug 2008142: Change web terminal subscription permissions from get to list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143 · 2021-10-06T10:43:34Z

/bugzilla refresh

openshift-ci · 2021-10-06T10:43:41Z

@sahil143: This pull request references Bugzilla bug 2008142, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2006329 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 2006329 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhadvig

/lgtm

openshift-bot · 2021-10-07T13:42:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-07T13:55:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-07T15:52:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-07T18:02:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-07T20:12:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-07T22:44:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-08T01:20:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-08T03:44:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

christianvogt · 2021-11-01T15:47:21Z

/label backport-risk-assessed

openshift-ci · 2021-11-01T15:47:22Z

@christianvogt: Can not set label backport-risk-assessed: Must be member in one of these teams: []

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christianvogt · 2021-11-01T15:48:00Z

@spadgett @jhadvig can you deal with /label backport-risk-assessed as I do not have permission

openshift-ci · 2021-11-01T15:56:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, JPinkney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spadgett · 2021-11-01T16:03:38Z

/label backport-risk-assessed

JPinkney · 2021-11-03T15:06:45Z

@spadgett @jhadvig Looks like it needs the cherry-pick-approved label as well

hardys · 2021-11-09T14:14:55Z

@spadgett @jhadvig Looks like it needs the cherry-pick-approved label as well

[patch-manager] Per the prow config for this repo, that label should be applied by one of @yapei @yanpzhan

yapei · 2021-11-10T06:21:42Z

@sanketpathak Could you help verify the fix so that we can add cherry-pick-approved label?

sanketpathak · 2021-11-16T12:01:37Z

Verified the UI with the pr changes using a cluster bot, works as expected, followed the steps from the pr #10135

1. Login as normal user or admin and create a web terminal. Verify that everything is working as expected
2. Create a new subscription in a different namespace. Verify that the console will fail to open the next time with an error saying: found multiple subscriptions for web-terminal when only one should be found
3. Remove the subscription and verify that opening the terminal will work again

/label cherry-pick-approved

openshift-ci · 2021-11-16T12:01:38Z

@sanketpathak: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

Verified the UI with the pr changes using a cluster bot, works as expected, followed the steps from the pr #10135

1. Login as normal user or admin and create a web terminal. Verify that everything is working as expected
2. Create a new subscription in a different namespace. Verify that the console will fail to open the next time with an error saying: found multiple subscriptions for web-terminal when only one should be found
3. Remove the subscription and verify that opening the terminal will work again

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sanketpathak · 2021-11-16T12:02:23Z

@yapei Now you can add the cherry-pick-approved label

jhadvig · 2021-11-16T13:02:43Z

/label cherry-pick-approved

openshift-ci · 2021-11-16T13:02:44Z

@jhadvig: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yapei · 2021-11-17T01:02:26Z

/label cherry-pick-approved

openshift-bot · 2021-11-17T04:36:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-17T05:39:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-17T07:27:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-17T09:03:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-17T11:28:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

JPinkney · 2021-11-17T13:28:37Z

/retest

openshift-bot · 2021-11-17T14:29:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-17T16:55:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-17T18:46:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-17T20:02:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-17T23:43:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-18T02:32:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-18T03:47:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-18T04:48:33Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-18T05:00:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-18T06:56:29Z

@JPinkney: All pull requests linked via external trackers have merged:

Bugzilla bug 2008142 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.9] Bug 2008142: Change web terminal subscription permissions from get to list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Change web terminal subscription permissions from get to list

451f6a4

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> (cherry picked from commit 84d500a)

openshift-ci Bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Sep 27, 2021

openshift-ci Bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 27, 2021

openshift-ci Bot requested review from jhadvig and spadgett September 27, 2021 12:32

openshift-ci Bot requested a review from sanketpathak October 6, 2021 10:43

jhadvig approved these changes Oct 7, 2021

View reviewed changes

jhadvig changed the title ~~(4.9 Backport) Bug 2008142: Change web terminal subscription permissions from get to list~~ [release-4.9] Bug 2008142: Change web terminal subscription permissions from get to list Oct 7, 2021

openshift-ci Bot assigned jhadvig Oct 7, 2021

openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2021

openshift-ci Bot mentioned this pull request Oct 30, 2021

(4.9 Backport) Bug 2008142: Allow web terminal to be installed in any namespace openshift/console#10135

Merged

jhadvig approved these changes Nov 1, 2021

View reviewed changes

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 17, 2021

openshift-merge-robot merged commit 0ff9519 into openshift:release-4.9 Nov 18, 2021

Conversation

JPinkney commented Sep 27, 2021

Uh oh!

openshift-ci Bot commented Sep 27, 2021

Uh oh!

sahil143 commented Oct 6, 2021

Uh oh!

openshift-ci Bot commented Oct 6, 2021

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Oct 7, 2021

Uh oh!

openshift-bot commented Oct 7, 2021

Uh oh!

openshift-bot commented Oct 7, 2021

Uh oh!

openshift-bot commented Oct 7, 2021

Uh oh!

openshift-bot commented Oct 7, 2021

Uh oh!

openshift-bot commented Oct 7, 2021

Uh oh!

openshift-bot commented Oct 8, 2021

Uh oh!

openshift-bot commented Oct 8, 2021

Uh oh!

christianvogt commented Nov 1, 2021

Uh oh!

openshift-ci Bot commented Nov 1, 2021

Uh oh!

christianvogt commented Nov 1, 2021

Uh oh!

openshift-ci Bot commented Nov 1, 2021

Uh oh!

spadgett commented Nov 1, 2021

Uh oh!

JPinkney commented Nov 3, 2021

Uh oh!

hardys commented Nov 9, 2021

Uh oh!

yapei commented Nov 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanketpathak commented Nov 16, 2021

Uh oh!

openshift-ci Bot commented Nov 16, 2021

Uh oh!

sanketpathak commented Nov 16, 2021

Uh oh!

jhadvig commented Nov 16, 2021

Uh oh!

openshift-ci Bot commented Nov 16, 2021

Uh oh!

yapei commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

JPinkney commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 18, 2021

yapei commented Nov 10, 2021 •

edited

Loading