(4.9 Backport) Bug 2008142: Allow web terminal to be installed in any namespace by JPinkney · Pull Request #10135 · openshift/console

JPinkney · 2021-09-24T20:19:51Z

This is a backport of #10045 to OpenShift 4.9.

Testing instructions (if neccessary):

Deploy the console changes to your cluster following https://github.com/openshift/console#steps with the image set as: quay.io/jpinkney/console:4.9-namespaces
Install web terminal catalogsource with the web terminal changes:

cat <<EOF | oc apply -f -
apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: custom-web-terminal-catalog
  namespace: openshift-marketplace
spec:
  displayName: Web Terminal Operator Catalog
  image: quay.io/jpinkney/web-terminal-operator-index@sha256:70e4f05ef522f1fd197db6a2cc364c36b1facf0af41d0303af6e7fbdc0bff0ba
  publisher: Red Hat
  sourceType: grpc
EOF

Create a subscription and operator group in a non openshift-operators namespace

# Create the test namespace
oc new-project web-terminal-test

# Create the operator group
cat <<EOF | oc apply -f -
apiVersion: operators.coreos.com/v1
kind: OperatorGroup
metadata:
  name: web-terminal-test
  namespace: web-terminal-test
EOF

# Create the subscription
cat <<EOF | oc apply -f -
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  name: web-terminal
  namespace: web-terminal-test
spec:
  channel: fast
  installPlanApproval: Automatic
  name: web-terminal
  source: custom-web-terminal-catalog
  sourceNamespace: openshift-marketplace
  startingCSV: web-terminal.v1.3.1
EOF

Make sure that the console operator has the correct permissions. It can be done easily by checking out this pr and then using:

watch -n 1 oc apply -f manifests/03-rbac-role-cluster.yaml

To actually verify that everything is working:

Login as normal user or admin and create a web terminal. Verify that everything is working as expected
Create a new subscription in a different namespace. Verify that the console will fail to open the next time with an error saying: found multiple subscriptions for web-terminal when only one should be found
Remove the subscription and verify that opening the terminal will work again

…inal is installed Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> (cherry picked from commit ef33f7f)

…mplates in the namespace where the web terminal operators is installed Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> (cherry picked from commit 090d664)

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> (cherry picked from commit 873001e)

(cherry picked from commit 613ef49)

(cherry picked from commit 0e749d5)

(cherry picked from commit 43b2508)

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> (cherry picked from commit 5d5e46c)

openshift-ci · 2021-09-24T20:19:55Z

@JPinkney: This pull request references Bugzilla bug 2006329, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.10.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
expected Bugzilla bug 2006329 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

(4.9 Backport) Bug 2006329: Allow web terminal to be installed in any namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-27T12:19:47Z

@JPinkney: This pull request references Bugzilla bug 2008142, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead
expected Bugzilla bug 2008142 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

(4.9 Backport) Bug 2008142: Allow web terminal to be installed in any namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JPinkney · 2021-09-27T12:19:57Z

/bugzilla refresh

openshift-ci · 2021-09-27T12:20:00Z

@JPinkney: This pull request references Bugzilla bug 2008142, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead
expected Bugzilla bug 2008142 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2021-09-27T12:35:29Z

/hold

spadgett · 2021-09-27T16:36:09Z

/hold cancel

christianvogt · 2021-10-01T13:30:24Z

/bugzilla refresh

openshift-ci · 2021-10-01T13:31:29Z

@christianvogt: This pull request references Bugzilla bug 2008142, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christianvogt · 2021-10-01T13:33:54Z

/bugzilla refresh

openshift-ci · 2021-10-01T13:34:00Z

@christianvogt: This pull request references Bugzilla bug 2008142, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2006329 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 2006329 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143 · 2021-10-06T10:42:39Z

/bugzilla refresh

openshift-ci · 2021-10-06T10:42:44Z

@sahil143: This pull request references Bugzilla bug 2008142, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2006329 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 2006329 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143

/lgtm

verified changes locally by installing the v1.3.1 in a namespace other than openshift-operators. Followed step mentioned in the description. The terminal is working as expected.

christianvogt · 2021-10-07T17:28:33Z

/approve

openshift-ci · 2021-10-07T17:29:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, JPinkney, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]
~~pkg/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

christianvogt · 2021-10-28T17:06:58Z

/label backport-risk-assessed

openshift-bot · 2021-10-30T00:33:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-30T00:46:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-30T04:52:47Z

@JPinkney: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/console-operator#596 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2008142 has not been moved to the MODIFIED state.

Details

In response to this:

(4.9 Backport) Bug 2008142: Allow web terminal to be installed in any namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ce-4.9-port (4.9 Backport) Bug 2008142: Allow web terminal to be installed in any namespace

JPinkney added 7 commits September 24, 2021 11:30

Introduce a new endpoint for getting the namespace where the web term…

d569ca3

…inal is installed Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> (cherry picked from commit ef33f7f)

Make the dashboard create web terminals that reference devworkspacete…

2fc9f02

…mplates in the namespace where the web terminal operators is installed Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> (cherry picked from commit 090d664)

Fix CloudShellTerminal tests now that namespace is autodetected

86c7cd8

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> (cherry picked from commit 873001e)

Refactor unrecoverableErrorFound

8cf99c6

(cherry picked from commit 613ef49)

Switch from React.useState to useSafetyFirst in async context

2c0193a

(cherry picked from commit 0e749d5)

Rename kubernetes error import to k8sErrors

7edd423

(cherry picked from commit 43b2508)

Ensure that all web terminal errors are send back to the frontend

9586258

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> (cherry picked from commit 5d5e46c)

openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 24, 2021

openshift-ci Bot requested review from jhadvig and zherman0 September 24, 2021 20:20

openshift-ci Bot added the component/core Related to console core functionality label Sep 24, 2021

JPinkney changed the title ~~(4.9 Backport) Bug 2006329: Allow web terminal to be installed in any namespace~~ (4.9 Backport) Bug 2008142: Allow web terminal to be installed in any namespace Sep 27, 2021

openshift-ci Bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Sep 27, 2021

JPinkney mentioned this pull request Sep 27, 2021

[release-4.9] Bug 2008142: Change web terminal subscription permissions from get to list openshift/console-operator#596

Merged

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2021

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2021

openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Oct 1, 2021

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 1, 2021

openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 1, 2021

openshift-ci Bot requested a review from sanketpathak October 1, 2021 13:34

sahil143 approved these changes Oct 7, 2021

View reviewed changes

openshift-ci Bot assigned sahil143 Oct 7, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2021

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 28, 2021

stleerh added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 29, 2021

openshift-merge-robot merged commit 39af3f9 into openshift:release-4.9 Oct 30, 2021

christoph-jerolimov mentioned this pull request Jan 4, 2022

[release-4.8] Bug 2008141: Allow web terminal to be installed in any namespace #10134

Merged

meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025

Merge pull request openshift#10135 from JPinkney/web-terminal-namespa…

8149184

…ce-4.9-port (4.9 Backport) Bug 2008142: Allow web terminal to be installed in any namespace

Conversation

JPinkney commented Sep 24, 2021

Uh oh!

openshift-ci Bot commented Sep 24, 2021

Uh oh!

openshift-ci Bot commented Sep 27, 2021

Uh oh!

JPinkney commented Sep 27, 2021

Uh oh!

openshift-ci Bot commented Sep 27, 2021

Uh oh!

spadgett commented Sep 27, 2021

Uh oh!

spadgett commented Sep 27, 2021

Uh oh!

christianvogt commented Oct 1, 2021

Uh oh!

openshift-ci Bot commented Oct 1, 2021

Uh oh!

christianvogt commented Oct 1, 2021

Uh oh!

openshift-ci Bot commented Oct 1, 2021

Uh oh!

sahil143 commented Oct 6, 2021

Uh oh!

openshift-ci Bot commented Oct 6, 2021

Uh oh!

sahil143 left a comment

Choose a reason for hiding this comment

Uh oh!

christianvogt commented Oct 7, 2021

Uh oh!

openshift-ci Bot commented Oct 7, 2021

Uh oh!

christianvogt commented Oct 28, 2021

Uh oh!

openshift-bot commented Oct 30, 2021

Uh oh!

openshift-bot commented Oct 30, 2021

Uh oh!

openshift-ci Bot commented Oct 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants