Skip to content

[release-4.8] Bug 2008141: Change web terminal subscription permissions from get to list#595

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
JPinkney:backport-web-terminal-subscription-permissions-4.8
Jan 28, 2022
Merged

[release-4.8] Bug 2008141: Change web terminal subscription permissions from get to list#595
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
JPinkney:backport-web-terminal-subscription-permissions-4.8

Conversation

@JPinkney
Copy link
Copy Markdown
Contributor

@JPinkney JPinkney commented Sep 27, 2021

This PR cherry-picks #588 back to 4.8. Related Console side PR backport for 4.8 is: openshift/console#10134

Signed-off-by: Josh Pinkney joshpinkney@gmail.com
(cherry picked from commit 84d500a)

@JPinkney
Change web terminal subscription permissions from get to list
b14124d 
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
(cherry picked from commit 84d500a)
@openshift-ci openshift-ci Bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 27, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2021

@JPinkney: This pull request references Bugzilla bug 2008141, which is invalid:

  • expected the bug to target the "4.8.z" release, but it targets "---" instead
  • expected Bugzilla bug 2008141 to depend on a bug targeting a release in 4.9.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

(4.8 Backport) Bug 2008141: Change web terminal subscription permissions from get to list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from jhadvig and spadgett September 27, 2021 12:27
@JPinkney JPinkney changed the title (4.8 Backport) Bug 2008141: Change web terminal subscription permissions from get to list (4.9 Backport) Bug 2008142: Change web terminal subscription permissions from get to list Sep 27, 2021
@JPinkney JPinkney changed the title (4.9 Backport) Bug 2008142: Change web terminal subscription permissions from get to list (4.8 Backport) Bug 2008141: Change web terminal subscription permissions from get to list Sep 27, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2021

@JPinkney: This pull request references Bugzilla bug 2008141, which is invalid:

  • expected the bug to target the "4.8.z" release, but it targets "---" instead
  • expected Bugzilla bug 2008141 to depend on a bug targeting a release in 4.9.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

(4.8 Backport) Bug 2008141: Change web terminal subscription permissions from get to list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2021

@JPinkney: This pull request references Bugzilla bug 2008142, which is invalid:

  • expected the bug to target the "4.8.z" release, but it targets "---" instead
  • expected Bugzilla bug 2008142 to depend on a bug targeting a release in 4.9.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

(4.9 Backport) Bug 2008142: Change web terminal subscription permissions from get to list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig jhadvig changed the title (4.8 Backport) Bug 2008141: Change web terminal subscription permissions from get to list [release-4.8] Bug 2008141: Change web terminal subscription permissions from get to list Oct 7, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 1, 2022

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

@openshift-ci openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 1, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 1, 2022

@openshift-bot: This pull request references Bugzilla bug 2008141, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2008142 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2008142 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from sanketpathak January 1, 2022 00:02
@christoph-jerolimov
Copy link
Copy Markdown
Member

christoph-jerolimov commented Jan 4, 2022 •
edited
Loading

/assign @jhadvig @christianvogt @jerolimov
/cc @jhadvig @christianvogt @jerolimov

As soon as we merge openshift/console#10134 we should merge this here as well, right?

@christoph-jerolimov
Copy link
Copy Markdown
Member

christoph-jerolimov commented Jan 6, 2022

/uncc
/unassign

@openshift-ci openshift-ci Bot removed the request for review from christoph-jerolimov January 6, 2022 08:36
@JPinkney
Copy link
Copy Markdown
Contributor Author

JPinkney commented Jan 6, 2022

Yes, both this PR and openshift/console#10134 must be merged at the same time

@christianvogt
Copy link
Copy Markdown

christianvogt commented Jan 10, 2022

/approve
/label backport-risk-assessed

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 10, 2022

@christianvogt: Can not set label backport-risk-assessed: Must be member in one of these teams: []

Details

In response to this:

/approve
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhadvig
jhadvig approved these changes Jan 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 28, 2022
@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Jan 28, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jhadvig, JPinkney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanketpathak
Copy link
Copy Markdown

sanketpathak commented Jan 28, 2022

Verified in cluster using cluster-bot
/qe-approved

@yapei
Copy link
Copy Markdown
Contributor

yapei commented Jan 28, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 28, 2022
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci Bot mentioned this pull request Jan 28, 2022
Merged
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 28, 2022

@JPinkney: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 494fd48 into openshift:release-4.8 Jan 28, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 28, 2022

@JPinkney: All pull requests linked via external trackers have merged:

Bugzilla bug 2008141 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.8] Bug 2008141: Change web terminal subscription permissions from get to list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@jhadvig jhadvig

@christianvogt christianvogt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@JPinkney @openshift-bot @christoph-jerolimov @christianvogt @jhadvig @sanketpathak @yapei @openshift-merge-robot