Add e2e test for /metrics endpoint#320
Add e2e test for /metrics endpoint#320benjaminapetersen wants to merge 24 commits intoopenshift:release-4.2from
Conversation
Update operator for project link API changes
Proxy e2e test
Fix NO_PROXY flake
It's possible that this process would run as PID 1 in a PID namespace, and PID 1 has special handling [1]: Only signals for which the "init" process has established a signal handler can be sent to the "init" process by other members of the PID namespace. That's unlikely to be important for termination, because CRI-O will be TERMing the process from outside the pod's PID namespace. With the coming PID-namespace sharing [2], you could set this container process up to not be PID 1 in any namespace. But regardless, gracefully exiting when we're asked to is polite behavior. In the future, we might want to add something here to delay exiting until we have finished serving any ongoing downloads (or at least give them a fair shot at finishing), but clients can always retry any downloads that fail because our pod was killed, so I'm not worrying about that now. [1]: http://man7.org/linux/man-pages/man7/pid_namespaces.7.html [2]: https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/
…s/migrate Remove extensions CRDs to migrate to openshift-config-operator
manifests/07-downloads-deployment: Catch and exit on TERM
…r-detach Make status handlers standalone helper funcs
…ew-console-operator-refactor Reorganize args to NewConsoleOperator func
Remove unused argument
…xtensions/return-home Temporarily return extension CRDs from cluster-config-operator to our Manifests dir
Add ConsoleCliDownloads controller
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
@benjaminapetersen: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hmm. Cherry pick messing' |
openshift-ci-robot
added
size/XXL
|
@benjaminapetersen: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
Cherry pick of the e2e test commit for metrics from: #299
/assign @jhadvig
/cc @spadgett