Skip to content

Remove extensions CRDs to migrate to openshift-config-operator#302

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
benjaminapetersen:crd/extensions/migrate
Oct 3, 2019
Merged

Remove extensions CRDs to migrate to openshift-config-operator#302
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
benjaminapetersen:crd/extensions/migrate

Conversation

@benjaminapetersen
Copy link
Copy Markdown
Contributor

@benjaminapetersen benjaminapetersen commented Sep 30, 2019 •
edited
Loading

These CRDs should live in cluster-config-operator.
openshift/cluster-config-operator#95

@spadgett @jhadvig fyi

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2019
@benjaminapetersen benjaminapetersen mentioned this pull request Sep 30, 2019
Merged
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2019
@benjaminapetersen
Copy link
Copy Markdown
Contributor Author

benjaminapetersen commented Oct 1, 2019

Error is :

NoSuchElementError: Index out of bound. Trying to access element at index: 0, but there are only 0 elements that match locator By(css selector, [data-test-rows="resource-row"])
    at selenium_webdriver_1.promise.all.then (/go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:274:27)
    at ManagedPromise.invokeCallback_ (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:1376:14)

So I am going to bet that the PR adding to cluster-config-operator must merge first else the resource isn't usable.

@benjaminapetersen
Copy link
Copy Markdown
Contributor Author

benjaminapetersen commented Oct 2, 2019

/retest

migration has merged openshift/cluster-config-operator#95

@benjaminapetersen
Copy link
Copy Markdown
Contributor Author

benjaminapetersen commented Oct 2, 2019

/retest

Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
    at Timeout._onTimeout (/go/src/github.com/openshift/console/frontend/node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:4281:23)
    at ontimeout (timers.js:427:11)

@benjaminapetersen benjaminapetersen mentioned this pull request Oct 2, 2019
Merged
jhadvig
jhadvig approved these changes Oct 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 👍

@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Oct 3, 2019

/retest

@benjaminapetersen
Copy link
Copy Markdown
Contributor Author

benjaminapetersen commented Oct 3, 2019

@jhadvig or @spadgett care to tag? the migration merged, so we prob don't want 2 instances of these lingering around.

@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Oct 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benjaminapetersen
Copy link
Copy Markdown
Contributor Author

benjaminapetersen commented Oct 3, 2019

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ce6a896 into openshift:master Oct 3, 2019
@benjaminapetersen benjaminapetersen deleted the crd/extensions/migrate branch October 4, 2019 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjaminapetersen @jhadvig @openshift-ci-robot @openshift-bot @openshift-merge-robot