Temporarily return extension CRDs from cluster-config-operator to our Manifests dir#314
Conversation
openshift-ci-robot
added
size/L
spadgett
left a comment
spadgett
left a comment
There was a problem hiding this comment.
Can you add the YAML samples CRD as well?
| - name of the resource which containes the logs - ${resourceUID} - | ||
| UID of the resource which contains the logs - e.g. `11111111-2222-3333-4444-555555555555` | ||
| - ${containerName} - name of the resource's container that contains | ||
| the logs - ${resourceNamespace} - namespace of the resource that contains |
There was a problem hiding this comment.
This is missing resourceNamespaceUID from openshift/api#466
It would be good to fix the formatting here
There was a problem hiding this comment.
Yikes the generate definitely did not format this well.
There was a problem hiding this comment.
Bah, and we have a /hold on the updates with the patterns, so I'll have to reconcile by hand. 😢
(https://github.com/openshift/cluster-config-operator/pull/101/files)
benjaminapetersen
force-pushed
the
crd/console-extensions/return-home
branch
from
8750744 to
d5abbad
Compare
| - ${resourceNamespace} - namespace of the resource that contains the logs | ||
| - ${resourceNamespaceUID} - namespace UID of the resource that contains the logs | ||
| - ${podLabels} - JSON representation of labels matching the pod with the logs | ||
| - e.g. `{\"key1\":\"value1\",\"key2\":\"value2\"}` |
There was a problem hiding this comment.
Strangely the embedded " within the overall " seems to work fine, here.
|
/close |
|
@benjaminapetersen: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest @spadgett lets run with this one temporarily so we don't have a broken merge queue. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
benjaminapetersen
changed the title
|
/retest |
|
/retest |
4 participants
They shall return to us!
To make @deads2k happy 😄
/cc @spadgett @jhadvig
TODO as follow-up:
openshift/apitype definitions to avoid drift