Make status handlers standalone helper funcs#309
Make status handlers standalone helper funcs#309openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
approved
jhadvig
left a comment
jhadvig
left a comment
There was a problem hiding this comment.
Two small nits otherwise this is precisely what we need 👍
| klog.V(4).Infoln("console is in an unmanaged state.") | ||
| if !reflect.DeepEqual(updatedStatus, configs.Operator) { | ||
| c.SyncStatus(updatedStatus) | ||
|
|
| "fmt" | ||
| "os" | ||
|
|
||
| "github.com/openshift/console-operator/pkg/console/status" |
There was a problem hiding this comment.
nit: lets put this to the rest of the openshift pkgs
benjaminapetersen
force-pushed
the
status/handler-detach
branch
from
b5f51d6 to
178899f
Compare
|
Updated! |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest
|
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 participants
Make status handlers standalone helper funcs that can be used across controllers
This makes them useful now that we want to break off into separate controllers. See:
/assign @jhadvig @spadgett