Bug 2033720: Bump k8 dependencies to v0.23.1#409
Bug 2033720: Bump k8 dependencies to v0.23.1#409openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
approved
|
this will need openshift/release#25443 for the compile to work in CI |
| k8s.io/client-go v0.23.1 | ||
| ) | ||
|
|
||
| require ( |
There was a problem hiding this comment.
I tried the bump locally and did not need all this require stuff @dperaza4dustbit
remove it and re-run go mod tidy then go mod vendor
if for some reason you can't do this on your Mac without this, then I'll submit an alternative PR
There was a problem hiding this comment.
Did you move go to 1.7 at the top of go.mod?
There was a problem hiding this comment.
yep your are right @dperaza4dustbit
and now looking at it again, I see it now does 1 require blocks ... the top one with direct dependencies and the bottom one with indirect one
let's leave as is and retest after merging the release PRs
|
ok master branch ocp is now golang 1.17 ... let's see /retest |
|
still built with 1.16 ... may have retest too soon where the changes were not pushed everywhere needed let's wait a bit, then try again |
dperaza4dustbit
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
/test images |
|
@dperaza4dustbit: This pull request references Bugzilla bug 2033720, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
|
@dperaza4dustbit if the images job fails again with it still using golang 1.16 we may have to change the Dockerfiles as well to get things to work (didn't think that was necessary but something might have changed) |
hmm did it again ... I'm confused, given the rehearsals passed ... still may be a slow CI sync that said, updating the Dockerfiles for local development is a good idea @dperaza4dustbit ... go ahead and update them in a separate commit |
dperaza4dustbit
force-pushed
the
bump_k8_dependencies
branch
from
8192b55 to
d47c845
Compare
| @@ -1,4 +1,4 @@ | |||
| FROM registry.svc.ci.openshift.org/openshift/release:golang-1.16 AS builder | |||
| FROM registry.ci.openshift.org/openshift/release:golang-1.17 AS builder | |||
There was a problem hiding this comment.
you need to change line 6 below too
FROM registry.ci.openshift.org/origin/4.10:base
There was a problem hiding this comment.
if the e2e's stay green I'll handle this in a separate PR
dperaza4dustbit
force-pushed
the
bump_k8_dependencies
branch
from
d47c845 to
8712312
Compare
|
/retest |
|
PR e2e's are sufficient testing /label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
/test unit |
|
/hold @dperaza4dustbit and I are investigating looks like the unit test still wants to run golang 1.16 for some reason |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test unit |
|
Note that #403 already exists to move to go1.17 |
|
/test unit see if we can get by without #403 where we just manually updated openshift/release (but their bot has not reverted us) |
|
/skip |
|
/test e2e-aws-operator |
|
/test unit |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: David Peraza <dperaza@redhat.com>
dperaza4dustbit
force-pushed
the
bump_k8_dependencies
branch
from
8712312 to
5b61623
Compare
|
/skip |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dperaza4dustbit, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
AWS fail /test e2e-aws-image-ecosystem |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@dperaza4dustbit: All pull requests linked via external trackers have merged:
Bugzilla bug 2033720 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dperaza4dustbit: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
Signed-off-by: David Peraza dperaza@redhat.com