Bug 2033720: sync imagestreams by yselkowitz · Pull Request #26750 · openshift/origin

yselkowitz · 2022-01-14T18:40:28Z

Sync examples
image_ecosystem: use unique tags in test logs
image_ecosystem: sync s2i image tags

openshift-ci · 2022-01-14T18:40:30Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2022-01-14T18:40:35Z

@yselkowitz: This pull request references Bugzilla bug 2033720, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

Bug 2033720: sync imagestreams

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yselkowitz · 2022-01-17T20:37:47Z

Waiting on openshift/cluster-samples-operator#408

dperaza4dustbit

looks good just one question on psql volume mount path

dperaza4dustbit · 2022-01-17T20:40:05Z

examples/quickstarts/nodejs-postgresql-persistent.json

 								},
 								"volumeMounts": [
 									{
-										"mountPath": "/var/lib/postgresql/data",


Are the image expecting this path change?

Not a change, but a bugfix; see nodeshift-starters/nodejs-rest-http-crud#228. Note that this brings it in line with other pg-based templates.

yselkowitz · 2022-01-17T23:05:40Z

/test all

yselkowitz · 2022-01-18T02:19:48Z

/retest

yselkowitz · 2022-01-19T01:22:14Z

/test all

yselkowitz · 2022-01-19T03:44:03Z

/retest

yselkowitz · 2022-01-19T04:15:09Z

/test all

Many imagestreams support both RHEL/UBI 7 and 8 based images of the same language runtime, so version is not necessarily unique but tag is.

This adds new ImageStreamTags in 4.10 (from RHEL/UBI 8.5 and RHSCL 3.8), and restores some default tags which are being supported for the full ten years on RHEL/UBI 8.

yselkowitz · 2022-01-20T06:51:11Z

/retest
/assign @adambkaplan
/cc @gabemontero @dperaza4dustbit

openshift-ci · 2022-01-20T08:54:34Z

@yselkowitz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gabemontero · 2022-01-20T13:14:23Z

/lgtm

yselkowitz · 2022-01-20T15:12:19Z

/assign @bparees

bparees · 2022-01-20T15:37:08Z

@dperaza4dustbit let's get you (or the appropriate person associated w/ the samples operator) added to:

https://github.com/openshift/origin/blob/master/OWNERS_ALIASES

that file is used here to ensure that team leads can approve PRs to test/extended/util/annotate/generated:

https://github.com/openshift/origin/blob/master/test/extended/util/annotate/generated/OWNERS

bparees · 2022-01-20T15:38:05Z

(and also the other owners files this PR touches)

bparees · 2022-01-20T15:39:07Z

/approve

openshift-ci · 2022-01-20T15:39:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~examples/db-templates/OWNERS~~ [bparees]
~~examples/image-streams/OWNERS~~ [bparees]
~~examples/jenkins/OWNERS~~ [bparees,gabemontero]
~~examples/quickstarts/OWNERS~~ [bparees]
~~test/extended/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-01-20T15:43:36Z

@yselkowitz: Some pull requests linked via external trackers have merged:

openshift/cluster-samples-operator#408

The following pull requests linked via external trackers have not merged:

openshift/cluster-samples-operator#409 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2033720 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2033720: sync imagestreams

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Jan 14, 2022

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 14, 2022

openshift-ci bot requested review from adambkaplan, ashishkamra and jitendar-singh January 14, 2022 18:40

dperaza4dustbit reviewed Jan 17, 2022

View reviewed changes

yselkowitz force-pushed the imagestreams branch 2 times, most recently from 86f7513 to 4afbb59 Compare January 19, 2022 04:14

yselkowitz added 3 commits January 19, 2022 15:11

Sync examples

194ea71

image_ecosystem: use unique tags in test logs

bb94929

Many imagestreams support both RHEL/UBI 7 and 8 based images of the same language runtime, so version is not necessarily unique but tag is.

image_ecosystem: sync s2i image tags

e56fb69

This adds new ImageStreamTags in 4.10 (from RHEL/UBI 8.5 and RHSCL 3.8), and restores some default tags which are being supported for the full ten years on RHEL/UBI 8.

yselkowitz force-pushed the imagestreams branch from 4afbb59 to e56fb69 Compare January 19, 2022 20:11

yselkowitz marked this pull request as ready for review January 20, 2022 04:58

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2022

openshift-ci bot assigned adambkaplan Jan 20, 2022

openshift-ci bot requested review from dperaza4dustbit and gabemontero January 20, 2022 06:51

openshift-ci bot assigned gabemontero Jan 20, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022

openshift-ci bot assigned bparees Jan 20, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022

openshift-merge-robot merged commit 79b83ad into openshift:master Jan 20, 2022

This was referenced Jan 20, 2022

Bug 2033720: Bump k8 dependencies to v0.23.1 openshift/cluster-samples-operator#409

Merged

Bug 2033720: Synching SSO library openshift/cluster-samples-operator#411

Merged

yselkowitz deleted the imagestreams branch April 29, 2022 20:28

Conversation

yselkowitz commented Jan 14, 2022

Uh oh!

openshift-ci bot commented Jan 14, 2022

Uh oh!

openshift-ci bot commented Jan 14, 2022

Uh oh!

yselkowitz commented Jan 17, 2022

Uh oh!

dperaza4dustbit left a comment

Choose a reason for hiding this comment

Uh oh!

dperaza4dustbit Jan 17, 2022

Choose a reason for hiding this comment

Uh oh!

yselkowitz Jan 17, 2022

Choose a reason for hiding this comment

Uh oh!

yselkowitz commented Jan 17, 2022

Uh oh!

yselkowitz commented Jan 18, 2022

Uh oh!

yselkowitz commented Jan 19, 2022

Uh oh!

yselkowitz commented Jan 19, 2022

Uh oh!

yselkowitz commented Jan 19, 2022

Uh oh!

yselkowitz commented Jan 20, 2022

Uh oh!

openshift-ci bot commented Jan 20, 2022

Uh oh!

gabemontero commented Jan 20, 2022

Uh oh!

yselkowitz commented Jan 20, 2022

Uh oh!

bparees commented Jan 20, 2022

Uh oh!

bparees commented Jan 20, 2022

Uh oh!

bparees commented Jan 20, 2022

Uh oh!

openshift-ci bot commented Jan 20, 2022

Uh oh!

openshift-ci bot commented Jan 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments