Bug 2033720: Library synchronization for OCP 4.10#408
Conversation
openshift-ci
bot
added
the
approved
|
/retitle Bug 2033720: Library synchronization for OCP 4.10 |
openshift-ci
bot
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@dperaza4dustbit: This pull request references Bugzilla bug 2033720, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test unit |
|
Hmm.... 2 ruby tests are now failing in image eco @dperaza4dustbit @yselkowitz See if you can look at the logs @dperaza4dustbit to sort our what happened. Most likely a change in the upstream scl org broke something. If you get stuck ping me and I'll lend a second set of eyes on them. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
I'm baffled, the only ruby&rails changes were to 1) groupify APIs, 2) migrate the templates from ruby 2.6 to 2.7, and 3) add ruby 3.0 IST. The JSON files don't show any errors, I don't see any typos in the groupification, and I have no problem building the rails-ex with 2.7 using s2i. What exactly is the issue? |
|
@yselkowitz I'm gathering information so I can open an issue here: https://github.com/sclorg/rails-ex So far this caught our attention: 2022-01-18T02:35:47.654396810Z Bundle complete! 18 Gemfile dependencies, 59 gems now installed. Aslo this: 2022-01-18T02:36:02.047220049Z LoadError: cannot load such file -- bundler/setup 2022-01-18T02:36:02.047358987Z (See full trace by running task with --trace) 2022-01-18T02:36:08.795530068Z error: build error: error building at STEP "RUN /bin/sh -ic 'bundle exec rake test'": error while running runtime: exit status 1 Any of this rings any bells? ^^^^^ |
|
I'm also going to make a manual change to assets to try to narrow down more what change triggers this issue. |
one more nugget wrt what @dperaza4dustbit is doing with ^^, among other things, @dperaza4dustbit and I saw that the template's BuildConfig was bumped from 2.6 ruby to 2.7 ruby, but they also added 3.0 ruby to the imagestream... maybe the rails-ex repo is such now that the template's BC needs to use 3.0 ruby ? that conjecture may be discussed in the rails-ex issue he opens based on the investigation he is doing |
|
No, the only recent changes to rails-ex were in the templates, not the sample code. |
then the bump from 2.6 to 2.7 affected the processing of the ruby gem stuff such that the openshift build breaks, I've started an image eco run in @dperaza4dustbit 's other active PR, #406 if it fails in the same spot as well, then it is the latter guess, and we most likely have to disable that test while it gets sorted out in upstream SCL (unless your ruby know how figures it out @yselkowitz) if the former proves to be the case, @dperaza4dustbit reverts the bump of the ruby rails template in this PR so it still uses 2.6, and upstream SCL is still has to be contacted, unless your ruby know how figures it out @yselkowitz |
|
I believe sclorg/rails-ex#140 will fix the rails templates. |
|
In the meantime, #406's test failures help establish a baseline for this one:
Therefore the rails template fix should handle the only actual regression here? |
dperaza4dustbit
force-pushed
the
resync_libs_ocp4.10
branch
from
2af1e9c to
007e955
Compare
|
@dperaza4dustbit your repush did not include sclorg/rails-ex#140, which currently would have to be applied manually, e.g. |
|
so @dperaza4dustbit I am good with manually applying all of @yselkowitz fix for ruby/rails here, vs. waiting for them to merge and then for openshift/library to pick it up sounds like based on @yselkowitz 's #408 (comment) you need to do a bit more to make that happen Next, wrt any okd-e2e-aws-builds failures, unless they are directly related to an imagestream or template, we can skip that optional test. The OOM error code thing is not a blocker for this PR. the upgrade job flakes a bit; again unrelated to this PR; we'll just need to retest until we get past the flake and a clean run for okd image eco, let's do some best effort due diligence to sort out any imagestream/template issue (the last failure was an unrelated install problem). If it is an easy fix, we go for it. If it is not, we do not block this PR, skip that optional test, and open a bugzilla or github issue on the owning component/repo for dotnet or whatever it was that was failing. |
I see @yselkowitz so for all architecture. Let me make that change |
dperaza4dustbit
force-pushed
the
resync_libs_ocp4.10
branch
from
007e955 to
2f18732
Compare
Thanks @gabemontero just applied the changes to all rail templates and updated this PR, will check and open issues on OKD side. |
|
cluster start fail with ocp image eco ... trying again, just that one /test e2e-aws-image-ecosystem |
took a peak the the logs / must gather for this run, and it looks like a flake pulling from the internal OCP registry; the imagestream tag for dotnet:3.1-el7 imported fine from registry.centos.org we'll see what happens with a next test run
|
|
there are still some failures with ruby in the latest e2e-aws-image-ecosystem @dperaza4dustbit at https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-samples-operator/408/pull-ci-openshift-cluster-samples-operator-master-e2e-aws-image-ecosystem/1483862526675390464 see if you can triage / diagnose like we did together yesterday also, based on the discussion I see @yselkowitz having upstream, maybe another upstream PR (134) is needed ? |
|
It turns out my workaround was enough to get the template to first deploy, but a similar issue occurs later in the process when a regeneration is triggered, which involves a (different) |
|
On Wed, Jan 19, 2022 at 3:21 PM Yaakov Selkowitz ***@***.***> wrote:
It turns out my workaround was enough to get the template to first deploy,
but a similar issue occurs later in the process when a regeneration is
triggered, which involves a (different) bundle exec command. Therefore,
either rails-ex gets properly fixed for compatibility with Rails 2.7+
(which may not happen quickly enough), or we revert the rails templates to
2.6-ubi8 (which isn't great given that version is EOL in March). Either
way, you can back out my attempted change.
yeah going back to 2.6 even if it eols soon is what we’ll have to do;
there is precedence; the image is still pullable from the
registry/catalog
… —
Reply to this email directly, view it on GitHub
<#408 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3NU5H7SDAEYZ62BFPFOO3UW4MLHANCNFSM5MFQFU2Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ok thanks for investigation @gabemontero and @yselkowitz making the changes in assets to revert bundle exec changes and revert back to 2.6-ubi8 |
dperaza4dustbit
force-pushed
the
resync_libs_ocp4.10
branch
from
2f18732 to
f99a7bf
Compare
|
/retest |
|
Remaining test failures are pre-existing or flakes |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dperaza4dustbit, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-proxy |
|
@dperaza4dustbit: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2033720 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dperaza4dustbit: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
Performed ./library-sync.sh and pushing new assets.