Skip to content

Bug 2033720: Drop usage of old imagestreams#26708

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
yselkowitz:imagestreams
Jan 5, 2022
Merged

Bug 2033720: Drop usage of old imagestreams#26708
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
yselkowitz:imagestreams

Conversation

@yselkowitz
Copy link
Contributor

@yselkowitz yselkowitz commented Dec 17, 2021

The SCL team dropped this from imagestreams earlier than expected.

- cluster: update nodejs-postgresql quickstart to nodejs:14-ubi8

  • image_ecosystem: remove nodejs:12-ubi8
  • jenkins: update templates for nodejs:14-ubi8

@openshift-ci openshift-ci bot requested review from adambkaplan and dmage December 17, 2021 04:51
@yselkowitz yselkowitz changed the title Drop usage of nodejs:12-ubi8 Bug 2033720: Drop usage of nodejs:12-ubi8 Dec 17, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@yselkowitz: This pull request references Bugzilla bug 2033720, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

Bug 2033720: Drop usage of nodejs:12-ubi8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz yselkowitz changed the title Bug 2033720: Drop usage of nodejs:12-ubi8 Bug 2033720: Drop usage of old imagestreams Dec 17, 2021
@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jan 4, 2022

/retest
/cc @akram
/assign @adambkaplan

@openshift-ci openshift-ci bot requested a review from akram January 4, 2022 21:03
@yselkowitz
Copy link
Contributor Author

yselkowitz commented Jan 5, 2022

/retest

adambkaplan
adambkaplan reviewed Jan 5, 2022
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@yselkowitz one question about changes to the bluegreen-pipeline template, otherwise looks good.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
adambkaplan
adambkaplan approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

@yselkowitz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2d0f9f7 into openshift:master Jan 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 2033720 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2033720: Drop usage of old imagestreams

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dperaza4dustbit
Copy link
Contributor

dperaza4dustbit commented Jan 5, 2022

/lgtm

This was referenced Jan 20, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@dmage dmage Awaiting requested review from dmage

@jitendar-singh jitendar-singh Awaiting requested review from jitendar-singh

@akram akram Awaiting requested review from akram

Assignees

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yselkowitz @dperaza4dustbit @adambkaplan @openshift-merge-robot

Comments