Skip to content

OPRUN-3401: Add ocp variants annotations #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Nov 19, 2024
Merged

OPRUN-3401: Add ocp variants annotations #88

openshift-merge-bot merged 2 commits into from
Nov 19, 2024

Conversation

@LalatenduMohanty
Copy link
Member

@LalatenduMohanty LalatenduMohanty commented Nov 18, 2024 •
edited
Loading

This PR reverts #87 and adds a commit to fix the issue which was breaking hypershift tech-preview jobs

#87 was a revert of #86

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2024

@LalatenduMohanty: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2024
@LalatenduMohanty LalatenduMohanty force-pushed the add_ocp_variants_annotations branch from 6eed0e0 to 3681704 Compare November 18, 2024 19:54
@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented Nov 18, 2024

/hold as this is work in progress

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
everettraven
everettraven reviewed Nov 18, 2024
View reviewed changes
everettraven
everettraven reviewed Nov 18, 2024
View reviewed changes
@LalatenduMohanty LalatenduMohanty force-pushed the add_ocp_variants_annotations branch 3 times, most recently from 077e1b6 to 57888eb Compare November 18, 2024 20:11
@LalatenduMohanty
Removing single-node-developer annotations
c431ff5 
This PR reverts openshift#87 and commit.

With these changes we do not deploy on top of hypershift, so wont break
hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
@LalatenduMohanty LalatenduMohanty force-pushed the add_ocp_variants_annotations branch from 57888eb to c431ff5 Compare November 18, 2024 20:15
@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented Nov 18, 2024

/payload-job periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@LalatenduMohanty: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ec902f50-a5e9-11ef-8412-14cbf591bfb6-0

@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented Nov 18, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@tmshort tmshort mentioned this pull request Nov 18, 2024
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@tmshort: This PR was included in a payload test run from openshift/origin#29304
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/04c164b0-a5ed-11ef-9e2d-231b98ee4413-0

@joelanford
Copy link
Member

joelanford commented Nov 19, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e56e784 into openshift:main Nov 19, 2024
@openshift-bot
Copy link

openshift-bot commented Nov 19, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-olm-operator
This PR has been included in build ose-cluster-olm-operator-container-v4.19.0-202411191537.p0.ge56e784.assembly.stream.el9.
All builds following this will include this PR.

@grokspawn
Copy link
Contributor

grokspawn commented Nov 20, 2024 •
edited by openshift-ci bot
Loading

/retitle OPRUN-3401: Add ocp variants annotations

@openshift-ci openshift-ci bot changed the title NO-ISSUE: Add ocp variants annotations OPRUN-3401: Add ocp variants annotations Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford joelanford left review comments

@grokspawn grokspawn Awaiting requested review from grokspawn

@perdasilva perdasilva Awaiting requested review from perdasilva

+1 more reviewer

@everettraven everettraven everettraven left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@joelanford joelanford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LalatenduMohanty @openshift-ci-robot @joelanford @openshift-bot @grokspawn @everettraven