Skip to content

Conversation

@perdasilva
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 15, 2024
@openshift-ci-robot
Copy link

@perdasilva: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kevinrizza and m1kola November 15, 2024 13:10
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@perdasilva perdasilva force-pushed the add-variant-annotations branch from b0dffa8 to 7c2cb9d Compare November 15, 2024 14:07
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the add-variant-annotations branch from 7c2cb9d to 94266e5 Compare November 15, 2024 14:10
@joelanford
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [joelanford,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

@perdasilva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 94266e5 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit be79dc3 into openshift:main Nov 15, 2024
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-olm-operator
This PR has been included in build ose-cluster-olm-operator-container-v4.18.0-202411151807.p0.gbe79dc3.assembly.stream.el9.
All builds following this will include this PR.

LalatenduMohanty added a commit to LalatenduMohanty/cluster-olm-operator that referenced this pull request Nov 18, 2024
This PR reverts openshift#87 and
adds a commit to fix the issue which was breaking hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty added a commit to LalatenduMohanty/cluster-olm-operator that referenced this pull request Nov 18, 2024
This PR reverts openshift#87 and
adds a commit to fix the issue which was breaking hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty added a commit to LalatenduMohanty/cluster-olm-operator that referenced this pull request Nov 18, 2024
This PR reverts openshift#87 and
adds a commit to fix the issue which was breaking hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty added a commit to LalatenduMohanty/cluster-olm-operator that referenced this pull request Nov 18, 2024
This PR reverts openshift#87 and
adds a commit to fix the issue which was breaking hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty added a commit to LalatenduMohanty/cluster-olm-operator that referenced this pull request Nov 18, 2024
This PR reverts openshift#87 and commit.

With these changes we do not deploy on top of hypershift, so wont break
hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants