OCPBUGS-44662: Re-enable OLMv1 tests #29304
Conversation
tmshort
commented
Nov 18, 2024
tmshort
commented
- Cleanup and reorganize some tests.
- Add some negative tests.
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
jira/valid-reference
|
@tmshort: This pull request references Jira Issue OCPBUGS-44662, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/test e2e-gcp-ovn-techpreview |
|
/jira refresh |
|
@tmshort: This pull request references Jira Issue OCPBUGS-44662, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@tmshort: This pull request references Jira Issue OCPBUGS-44662, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tmshort
force-pushed
the
add-olm-tests
branch
from
f1576cc to
e6788be
Compare
|
/test e2e-gcp-ovn-techpreview |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
| ) | ||
|
|
||
| var _ = g.Describe("[sig-olmv1] OLMv1 CRDs", func() { | ||
| var _ = g.Describe("[sig-olmv1][OCPFeatureGate:NewOLM] OLMv1 CRDs", func() { |
There was a problem hiding this comment.
@tmshort just confirming, we need [OCPFeatureGate:NewOLM] so that we can continue run the test on default payload?
There was a problem hiding this comment.
This is also what the "5 e2es with 14 runs" check for promotion to default payload looks for.
There was a problem hiding this comment.
But yes, there is machinery that enables tests based on which feature gates are enabled in the cluster. That means that whenever we add ourselves to the default payload, the test runner will know to run these tests against the default payload.
test/extended/olm/olmv1.go
Outdated
| { | ||
| group: olmv1GroupName, | ||
| version: []string{"v1alpha1", "v1"}, | ||
| version: "v1", |
There was a problem hiding this comment.
I would like have a slice of strings, so that in future when we have v2 we do not have to change it again.
* Cleanup and reorganize some tests. * Add some negative tests. Signed-off-by: Todd Short <[email protected]>
tmshort
force-pushed
the
add-olm-tests
branch
from
e6788be to
7de0952
Compare
|
/test e2e-gcp-ovn-techpreview When the tests are refreshed, this one (for techpreview) always has to be added back in. |
|
/test what-is-available |
|
@tmshort: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tmshort: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn openshift/cluster-olm-operator#88 |
|
@tmshort: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/04c164b0-a5ed-11ef-9e2d-231b98ee4413-0 |
|
/approve Feel free to release hold when payload testing passes |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, stbenjam, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
techpreview passed |
|
None of the failures in https://pr-payload-tests.ci.openshift.org/runs/ci/04c164b0-a5ed-11ef-9e2d-231b98ee4413-0 seem related to olmv1 /unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@tmshort: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@tmshort: Jira Issue OCPBUGS-44662: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44662 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
6 participants
