Skip to content

Conversation

@xueqzhan
Copy link
Contributor

@xueqzhan xueqzhan commented Nov 18, 2024

Reverts #86 ; tracked by https://issues.redhat.com/browse/OCPBUGS-44675

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

4.18 CI hypershift job is failing due to OLM failing to be scheduled.

Relevant slack thread: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1731943727060319

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

CC: @perdasilva @joelanford

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2024
@openshift-ci-robot
Copy link

@xueqzhan: This pull request explicitly references no jira issue.

Details

In response to this:

Reverts #86

Testing now. Will update description once confirmed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xueqzhan
Copy link
Contributor Author

/payload-job periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2d11b740-a5c9-11ef-938d-65db0e358816-0

@openshift-ci openshift-ci bot requested review from m1kola and oceanc80 November 18, 2024 16:27
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@tmshort
Copy link
Contributor

tmshort commented Nov 18, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, tmshort, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2c502ca into openshift:main Nov 18, 2024
LalatenduMohanty added a commit to LalatenduMohanty/cluster-olm-operator that referenced this pull request Nov 18, 2024
This PR reverts openshift#87 and
adds a commit to fix the issue which was breaking hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty added a commit to LalatenduMohanty/cluster-olm-operator that referenced this pull request Nov 18, 2024
This PR reverts openshift#87 and
adds a commit to fix the issue which was breaking hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty added a commit to LalatenduMohanty/cluster-olm-operator that referenced this pull request Nov 18, 2024
This PR reverts openshift#87 and
adds a commit to fix the issue which was breaking hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty added a commit to LalatenduMohanty/cluster-olm-operator that referenced this pull request Nov 18, 2024
This PR reverts openshift#87 and
adds a commit to fix the issue which was breaking hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty added a commit to LalatenduMohanty/cluster-olm-operator that referenced this pull request Nov 18, 2024
This PR reverts openshift#87 and commit.

With these changes we do not deploy on top of hypershift, so wont break
hypershift tech-preview jobs

openshift#87 was a
revert of openshift#86

Signed-off-by: Lalatendu Mohanty <[email protected]>
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-olm-operator
This PR has been included in build ose-cluster-olm-operator-container-v4.19.0-202411182206.p0.g2c502ca.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants