-
Notifications
You must be signed in to change notification settings - Fork 33
Revert "NO-ISSUE: Add OCP variant annotations to manifests" #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "NO-ISSUE: Add OCP variant annotations to manifests" #87
Conversation
|
@xueqzhan: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn |
|
@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2d11b740-a5c9-11ef-938d-65db0e358816-0 |
LalatenduMohanty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, tmshort, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@xueqzhan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR reverts openshift#87 and adds a commit to fix the issue which was breaking hypershift tech-preview jobs openshift#87 was a revert of openshift#86 Signed-off-by: Lalatendu Mohanty <[email protected]>
This PR reverts openshift#87 and adds a commit to fix the issue which was breaking hypershift tech-preview jobs openshift#87 was a revert of openshift#86 Signed-off-by: Lalatendu Mohanty <[email protected]>
This PR reverts openshift#87 and adds a commit to fix the issue which was breaking hypershift tech-preview jobs openshift#87 was a revert of openshift#86 Signed-off-by: Lalatendu Mohanty <[email protected]>
This PR reverts openshift#87 and adds a commit to fix the issue which was breaking hypershift tech-preview jobs openshift#87 was a revert of openshift#86 Signed-off-by: Lalatendu Mohanty <[email protected]>
This PR reverts openshift#87 and commit. With these changes we do not deploy on top of hypershift, so wont break hypershift tech-preview jobs openshift#87 was a revert of openshift#86 Signed-off-by: Lalatendu Mohanty <[email protected]>
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-olm-operator |
Reverts #86 ; tracked by https://issues.redhat.com/browse/OCPBUGS-44675
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
4.18 CI hypershift job is failing due to OLM failing to be scheduled.
Relevant slack thread: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1731943727060319
To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:
/payload-job periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn
CC: @perdasilva @joelanford