CFE-846: Add user defined tags to the GCP buckets created#873
CFE-846: Add user defined tags to the GCP buckets created#873openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
bharath-b-rh
force-pushed
the
cfe-846
branch
3 times, most recently
from
57cee0b to
9f68dd1
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/remove-hold |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
bharath-b-rh
force-pushed
the
cfe-846
branch
2 times, most recently
from
849837a to
ac64d83
Compare
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
|
/jira refresh |
|
@bharath-b-rh: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bharath-b-rh
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@bharath-b-rh: This pull request references CFE-846 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
flavianmissi
left a comment
flavianmissi
left a comment
There was a problem hiding this comment.
looking good overall, left some comments
|
/label docs-approved |
|
this is looking great, we're almost there @bharath-b-rh! only a few small comments left |
|
HI, If i launch a cluster with cluster-bot, which installer pr or api pr, also needed? |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
@bharath-b-rh are there other PRs needed to test this? |
|
test failures seem flake related |
|
@flavianmissi @wewang58 : Yeah we need below installer PRs to test the feature. |
|
@bharath-b-rh do we need to merge the installer PRs and this one together in that case? sounds like this one won't work standalone. |
Yeah, I am working with installer team to get the PRs merged. If we merge this without installer code, user cannot define tags and the registry operator won't add any tags. But the operator as such can be deployed. |
|
/test e2e-aws-operator |
1 similar comment
|
/test e2e-aws-operator |
@bharath-b-rh tested as expect: http://pastebin.test.redhat.com/1107484, thanks |
|
/test e2e-aws-ovn-upgrade |
|
@bharath-b-rh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label qe-approved |
|
e2e failure seems unrelated |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-b-rh, flavianmissi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label docs-approved |
9 participants
PR has the changes for openshift/enhancements#1217 proposed to support GCP tags in OCP, which requires cluster-image-registry-operator to add gcp userTags available in the status sub resource of infrastructure CR, to the gcp buckets created by the operator.