Skip to content

CFE-686: Generate Infrastructure CR with the GCP user defined tags & labels#7138

Merged
patrickdillon merged 1 commit intoopenshift:masterfrom
bharath-b-rh:cfe-686
Aug 16, 2023
Merged

CFE-686: Generate Infrastructure CR with the GCP user defined tags & labels#7138
patrickdillon merged 1 commit intoopenshift:masterfrom
bharath-b-rh:cfe-686

Conversation

@bharath-b-rh
Copy link
Contributor

@bharath-b-rh bharath-b-rh commented Apr 27, 2023

PR:

  • Make GCP user tags and labels define din installconfig available in infrastructure CR created by installer for cluster operations.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 27, 2023 •
edited by openshift-ci bot
Loading

@bharath-b-rh: This pull request references CFE-686 which is a valid jira issue.

Details

In response to this:

PR:

  • Make GCP user tags and labels define din installconfig available in infrastructure CR created by installer for cluster operations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 27, 2023
@bharath-b-rh bharath-b-rh changed the title CFE-686: Generate Infrastructure CR with the GCP user defined tags & labels WIP: CFE-686: Generate Infrastructure CR with the GCP user defined tags & labels Apr 27, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2023
@openshift-ci openshift-ci bot requested review from AnnaZivkovic and rna-afk April 27, 2023 05:49
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented May 23, 2023

/hold openshift/enhancements#1217

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@bharath-b-rh bharath-b-rh marked this pull request as draft June 20, 2023 15:41
@bharath-b-rh bharath-b-rh force-pushed the cfe-686 branch 2 times, most recently from 99fa522 to 5b7dd67 Compare July 19, 2023 11:51
@jianli-wei
Copy link
Contributor

jianli-wei commented Aug 4, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 4, 2023
@bharath-b-rh bharath-b-rh changed the title WIP: CFE-686: Generate Infrastructure CR with the GCP user defined tags & labels CFE-686: Generate Infrastructure CR with the GCP user defined tags & labels Aug 9, 2023
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 9, 2023

/remove-hold

@bharath-b-rh bharath-b-rh marked this pull request as ready for review August 9, 2023 12:07
@openshift-ci openshift-ci bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 9, 2023
@openshift-ci openshift-ci bot requested a review from pawanpinjarkar August 9, 2023 12:14
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 9, 2023

/hold #7126

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@bharath-b-rh bharath-b-rh mentioned this pull request Aug 15, 2023
Merged
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 15, 2023

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2023
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 15, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 15, 2023

/retest-required

Remaining retests: 0 against base HEAD 8aff336 and 2 for PR HEAD 8cc2816 in total

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 16, 2023

Test history for this PR is weird. gcp tests haven't run for several commits!
image

/skip
/test e2e-gcp-ovn
/test e2e-gcp-secureboot
/test e2e-gcp-ovn-xpn

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 16, 2023

/retest-required

Remaining retests: 0 against base HEAD d55597a and 1 for PR HEAD 8cc2816 in total

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 16, 2023

/override ci/prow/okd-scos-images

1 similar comment
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 16, 2023

/override ci/prow/okd-scos-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon patrickdillon merged commit a012524 into openshift:master Aug 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

@bharath-b-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-shared-vpc 7c04ac0a8d0d1eb7d4f5d5ca5efc2c902f4a2219 link false /test e2e-gcp-ovn-shared-vpc
ci/prow/okd-scos-e2e-aws-ovn 8cc2816 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-upgrade 8cc2816 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn 8cc2816 link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bharath-b-rh bharath-b-rh deleted the cfe-686 branch August 16, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@rna-afk rna-afk Awaiting requested review from rna-afk

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bharath-b-rh @openshift-ci-robot @jianli-wei @patrickdillon

Comments