Skip to content

CFE-688: Update install-config CRD to support gcp labels and tags#7126

Merged
patrickdillon merged 1 commit intoopenshift:masterfrom
bharath-b-rh:cfe-688
Aug 15, 2023
Merged

CFE-688: Update install-config CRD to support gcp labels and tags#7126
patrickdillon merged 1 commit intoopenshift:masterfrom
bharath-b-rh:cfe-688

Conversation

@bharath-b-rh
Copy link
Contributor

@bharath-b-rh bharath-b-rh commented Apr 24, 2023

PR is for adding new fields userLabels and userTags for gcp platform type, to add user defined labels and tags to all those gcp resources created by installer.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2023 •
edited by openshift-ci bot
Loading

@bharath-b-rh: This pull request references CFE-688 which is a valid jira issue.

Details

In response to this:

PR is for adding new fields userLabels and userTags for gcp platform type, to add user defined labels and tags to all those gcp resources created by installer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2023
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Apr 24, 2023

/hold openshift/enhancements#1217

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@bharath-b-rh bharath-b-rh force-pushed the cfe-688 branch 2 times, most recently from 7f65334 to f623593 Compare July 12, 2023 08:03
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2023
@bharath-b-rh bharath-b-rh marked this pull request as draft August 1, 2023 11:21
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2023
@bharath-b-rh bharath-b-rh force-pushed the cfe-688 branch 2 times, most recently from f734be4 to 1d73d45 Compare August 1, 2023 13:58
@jianli-wei
Copy link
Contributor

jianli-wei commented Aug 4, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 4, 2023
@bharath-b-rh bharath-b-rh marked this pull request as ready for review August 5, 2023 15:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2023
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 5, 2023

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2023
@openshift-ci openshift-ci bot requested a review from bfournie August 5, 2023 15:09
patrickdillon
patrickdillon reviewed Aug 8, 2023
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 8, 2023

/retest-required

1 similar comment
@pawanpinjarkar
Copy link
Contributor

pawanpinjarkar commented Aug 8, 2023

/retest-required

@bharath-b-rh bharath-b-rh force-pushed the cfe-688 branch 2 times, most recently from cf39b5f to 102927c Compare August 9, 2023 14:48
This was referenced Aug 9, 2023
Merged
Merged
Merged
patrickdillon
patrickdillon reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The featuregate validation looks better but it is still not quite right (the default feature set is not populating the feature gates). But I think the feature gate validation is turning out to be a big lift and we should remove it from this PR, so that this PR can stay focused on the GCP labels and tags. I have started #7413 to handle the feature gate validation. That implementation stays pretty close to what is in the cluster-config-operator. Let's iterate on the feature gates in a separate PR and focus this one solely on the GCP labels and tags.

@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 10, 2023 •
edited
Loading

Let's iterate on the feature gates in a separate PR and focus this one solely on the GCP labels and tags.

I think keeping just the TechPreviewNoUpgrade condition for the feature and a separate PR to handle other FeatureSets should be fine?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

@bharath-b-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-ha-dualstack f6235933378fc8fcabf883d6691a95fd3cba6b30 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-metal-ipi-sdn-swapped-hosts 968e8c2948e48a6f48bbd5123f0a77ec63606405 link false /test e2e-metal-ipi-sdn-swapped-hosts
ci/prow/e2e-aws-ovn-shared-vpc 968e8c2948e48a6f48bbd5123f0a77ec63606405 link false /test e2e-aws-ovn-shared-vpc
ci/prow/e2e-openstack-ovn 968e8c2948e48a6f48bbd5123f0a77ec63606405 link true /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-sdn-virtualmedia 968e8c2948e48a6f48bbd5123f0a77ec63606405 link false /test e2e-metal-ipi-sdn-virtualmedia
ci/prow/okd-e2e-aws-ovn-upgrade 354d145 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack 968e8c2948e48a6f48bbd5123f0a77ec63606405 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-openstack-proxy 968e8c2948e48a6f48bbd5123f0a77ec63606405 link false /test e2e-openstack-proxy
ci/prow/e2e-metal-ipi-ovn-ipv6 968e8c2948e48a6f48bbd5123f0a77ec63606405 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/okd-e2e-aws-ovn 354d145 link false /test okd-e2e-aws-ovn
ci/prow/e2e-openstack-nfv-intel 968e8c2948e48a6f48bbd5123f0a77ec63606405 link false /test e2e-openstack-nfv-intel
ci/prow/e2e-openstack-sdn-parallel 968e8c2948e48a6f48bbd5123f0a77ec63606405 link false /test e2e-openstack-sdn-parallel
ci/prow/e2e-azurestack 968e8c2948e48a6f48bbd5123f0a77ec63606405 link false /test e2e-azurestack
ci/prow/e2e-metal-ipi-sdn 968e8c2948e48a6f48bbd5123f0a77ec63606405 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-vsphere-ovn 968e8c2948e48a6f48bbd5123f0a77ec63606405 link true /test e2e-vsphere-ovn
ci/prow/e2e-metal-assisted 968e8c2948e48a6f48bbd5123f0a77ec63606405 link false /test e2e-metal-assisted

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 14, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 14, 2023

/skip

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 15, 2023

/retest-required

Remaining retests: 0 against base HEAD db0eb03 and 2 for PR HEAD 354d145 in total

@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 15, 2023

/test e2e-gcp-ovn

@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 15, 2023

/retest

@bharath-b-rh bharath-b-rh mentioned this pull request Aug 15, 2023
Merged
@patrickdillon patrickdillon merged commit 8aff336 into openshift:master Aug 15, 2023
@bharath-b-rh bharath-b-rh deleted the cfe-688 branch August 15, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@bfournie bfournie Awaiting requested review from bfournie

+2 more reviewers

@r4f4 r4f4 r4f4 left review comments

@pawanpinjarkar pawanpinjarkar pawanpinjarkar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

@pawanpinjarkar pawanpinjarkar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bharath-b-rh @openshift-ci-robot @jianli-wei @pawanpinjarkar @patrickdillon @r4f4 @openshift-merge-robot