Skip to content

CFE-858: Update google terraform provider to latest version#7201

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
bharath-b-rh:cfe-858
Aug 17, 2023
Merged

CFE-858: Update google terraform provider to latest version#7201
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
bharath-b-rh:cfe-858

Conversation

@bharath-b-rh
Copy link
Contributor

@bharath-b-rh bharath-b-rh commented May 22, 2023 •
edited
Loading

PR is for updating the version of google terraform provider required making use of the latest APIs related to GCP tags and labels. The changes are required for supporting enhancement proposed here

Compute Instance and Cloud Storage GCP resources are not global but zonal and tagging these resources require providing the location where the said resources reside and the API for the same google_tags_location_tag_binding was made available in terraform-provider-google/releases#v4.51.0

Labels was added to ForwardingRule GCP resource and was made available in GA in terraform-provider-google/releases#v4.64.0

Now the google provider version has been updated to the latest version terraform-provider-google/releases#v4.74.0, which has the last commit

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2023
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented May 22, 2023

/cc @patrickdillon @barbacbd

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2023
bharath-b-rh
bharath-b-rh commented May 22, 2023
View reviewed changes
bharath-b-rh
bharath-b-rh commented May 22, 2023
View reviewed changes
bharath-b-rh
bharath-b-rh commented May 22, 2023
View reviewed changes
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented May 22, 2023

/retest-required

@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented May 22, 2023

/hold openshift/enhancements#1217

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2023
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented May 23, 2023

/test e2e-azure-ovn

@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented May 23, 2023

/test e2e-gcp-ovn-xpn

@bharath-b-rh bharath-b-rh changed the title CFE_858 : Update google terraform provider to latest version CFE-858 : Update google terraform provider to latest version May 23, 2023
@barbacbd
Copy link
Contributor

barbacbd commented May 23, 2023

There is already a newer version. There is a such a large queue to get merged, do you want to think about reopening with a newer version when we know items are being merged ?

@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented May 24, 2023

There is already a newer version. There is a such a large queue to get merged, do you want to think about reopening with a newer version when we know items are being merged ?

Yeah sure I can do that. Closing for now, to reopen once EP is merged.

@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Jul 19, 2023

/reopen

@openshift-ci openshift-ci bot reopened this Jul 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@bharath-b-rh: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bharath-b-rh bharath-b-rh marked this pull request as draft July 19, 2023 12:16
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2023
@bharath-b-rh bharath-b-rh force-pushed the cfe-858 branch 2 times, most recently from 9af1cbb to 02ee72d Compare July 19, 2023 12:24
@jianli-wei
Copy link
Contributor

jianli-wei commented Aug 4, 2023

/label qe-approved

patrickdillon
patrickdillon reviewed Aug 14, 2023
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check out the failing unit tests

/retest

@bharath-b-rh bharath-b-rh mentioned this pull request Aug 15, 2023
Merged
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 15, 2023

/retest-required

@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 15, 2023

/remove-hold

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 15, 2023

/lgtm

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 15, 2023

/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 15, 2023
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 16, 2023

/skip

1 similar comment
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 16, 2023

/skip

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 16, 2023

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 16, 2023

/retest-required

Remaining retests: 0 against base HEAD d55597a and 2 for PR HEAD 645708b in total

@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 16, 2023

/test okd-scos-images

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 16, 2023

/retest-required

Remaining retests: 0 against base HEAD a012524 and 1 for PR HEAD 645708b in total

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 16, 2023

/override ci/prow/okd-scos-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 16, 2023

/override ci/prow/okd-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-images

Details

In response to this:

/override ci/prow/okd-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023 •
edited
Loading

@bharath-b-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-shared-vpc 645708b link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-aws-ovn-shared-vpc 645708b link false /test e2e-aws-ovn-shared-vpc
ci/prow/e2e-azurestack 645708b link false /test e2e-azurestack
ci/prow/okd-e2e-aws-ovn-upgrade 645708b link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node 645708b link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-shared-vpc-localzones 645708b link false /test e2e-aws-ovn-shared-vpc-localzones
ci/prow/e2e-gcp-secureboot 645708b link false /test e2e-gcp-secureboot
ci/prow/e2e-aws-ovn-fips 645708b link false /test e2e-aws-ovn-fips
ci/prow/okd-scos-e2e-aws-ovn 645708b link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn 645708b link false /test okd-e2e-aws-ovn
ci/prow/e2e-aws-ovn-imdsv2 645708b link false /test e2e-aws-ovn-imdsv2
ci/prow/e2e-aws-ovn-localzones 645708b link false /test e2e-aws-ovn-localzones

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 17, 2023

/retest-required

Remaining retests: 0 against base HEAD f40d0ce and 0 for PR HEAD 645708b in total

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 17, 2023

/override ci/prow/e2e-azure-ovn
/override ci/prow/okd-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-azure-ovn, ci/prow/okd-images

Details

In response to this:

/override ci/prow/e2e-azure-ovn
/override ci/prow/okd-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4076411 into openshift:master Aug 17, 2023
@bharath-b-rh bharath-b-rh deleted the cfe-858 branch August 17, 2023 04:03
patrickdillon pushed a commit to patrickdillon/installer that referenced this pull request Oct 24, 2023
@openshift-merge-robot
Merge pull request openshift#7201 from bharath-b-rh/cfe-858
3505ffd 
CFE-858: Update google terraform provider to latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@barbacbd barbacbd Awaiting requested review from barbacbd

@sadasu sadasu Awaiting requested review from sadasu

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

+2 more reviewers

@r4f4 r4f4 r4f4 left review comments

@pawanpinjarkar pawanpinjarkar pawanpinjarkar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bharath-b-rh @barbacbd @jianli-wei @openshift-ci-robot @patrickdillon @r4f4 @pawanpinjarkar @openshift-merge-robot

Comments