Bug 2034484: Library go bump by eggfoobar · Pull Request #736 · openshift/cluster-image-registry-operator

eggfoobar · 2021-12-09T16:17:30Z

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

Changes:

updated library-go to use latest master branch
updated handler structs to use the new explicit handler structs

eggfoobar · 2021-12-13T19:00:32Z

/retest-required

dmage · 2021-12-13T21:45:30Z

Is it part of a Jira story or a BZ?

dmage · 2021-12-13T22:00:57Z

TestLeaderElection needs to be adjusted, apparently the new leader election is slower and the test needs to wait until these pods join the election process.

eggfoobar · 2021-12-13T22:34:13Z

Is it part of a Jira story or a BZ?

The Jira story this is tied to is CNF-3684

TestLeaderElection needs to be adjusted, apparently the new leader election is slower and the test needs to wait until these pods join the election process.

That's interesting, for non-SNO clusters the timing of 137/107/26 should not have been changed. Looking into it

jerpeter1 · 2021-12-22T14:20:06Z

/retest-required

ggiguash · 2021-12-23T20:23:58Z

/retest-required

ggiguash · 2021-12-27T09:15:41Z

/retest-required

ggiguash · 2022-01-04T16:25:15Z

/retest-required

openshift-ci · 2022-01-07T18:03:03Z

@eggfoobar: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request.

Details

In response to this:

Bug 2034484: Library go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ggiguash · 2022-01-12T14:22:49Z

/retest-required

ggiguash · 2022-01-15T10:19:06Z

/retest-required

ggiguash · 2022-01-18T11:11:50Z

/retest-required

eggfoobar · 2022-01-24T21:22:22Z

/assign @dmage

eggfoobar · 2022-01-25T17:17:07Z

/retest-required

fetched latest library-go and vendored dep updated handlers to use updated sctruct names updated okd builder image to use go 1.17 Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com> fix: pull in latest library-go pull in to grab fix described here openshift/library-go#1272 Signed-off-by: ehila <ehila@redhat.com> bump: library-go updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>

Signed-off-by: ehila <ehila@redhat.com>

delay check for leader election to wait for logs to write Signed-off-by: ehila <ehila@redhat.com>

dmage · 2022-01-25T17:37:25Z

/approve

dmage · 2022-01-25T21:57:21Z

/lgtm

openshift-ci · 2022-01-25T21:57:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, eggfoobar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dmage]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-01-25T22:36:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-01-26T00:29:56Z

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-operator	`659cdd9`	link	false	`/test e2e-gcp-operator`
ci/prow/e2e-ovirt	`a9f3dfc`	link	false	`/test e2e-ovirt`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-26T00:31:45Z

@eggfoobar: Bugzilla bug 2034484 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

Bug 2034484: Library go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2021

openshift-ci Bot requested review from bparees and smarterclayton December 9, 2021 16:19

eggfoobar force-pushed the library_go_bump branch 3 times, most recently from ce58f4f to f80443e Compare December 15, 2021 18:58

eggfoobar changed the title ~~[WIP] Library go bump~~ Library go bump Dec 15, 2021

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2021

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2021

eggfoobar force-pushed the library_go_bump branch from 659cdd9 to 475f1b9 Compare December 24, 2021 00:41

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 24, 2021

eggfoobar force-pushed the library_go_bump branch from 475f1b9 to 917bb93 Compare December 24, 2021 01:27

eggfoobar force-pushed the library_go_bump branch from 917bb93 to b4acfd7 Compare January 7, 2022 18:01

eggfoobar changed the title ~~Library go bump~~ Bug 2034484: Library go bump Jan 7, 2022

openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 7, 2022

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 7, 2022

eggfoobar force-pushed the library_go_bump branch from 5faa2a5 to 9a03203 Compare January 20, 2022 16:37

openshift-ci Bot assigned dmage Jan 24, 2022

eggfoobar added 3 commits January 25, 2022 12:37

upkeep: ran go mod tidy/vendor/verify

177c9dc

Signed-off-by: ehila <ehila@redhat.com>

test: updated unit test for leader election

a9f3dfc

delay check for leader election to wait for logs to write Signed-off-by: ehila <ehila@redhat.com>

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022

eggfoobar force-pushed the library_go_bump branch from 9ae421d to a9f3dfc Compare January 25, 2022 17:38

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022

openshift-merge-robot merged commit 37a7cc1 into openshift:master Jan 26, 2022

Conversation

eggfoobar commented Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eggfoobar commented Dec 13, 2021

Uh oh!

dmage commented Dec 13, 2021

Uh oh!

dmage commented Dec 13, 2021

Uh oh!

eggfoobar commented Dec 13, 2021

Uh oh!

jerpeter1 commented Dec 22, 2021

Uh oh!

ggiguash commented Dec 23, 2021

Uh oh!

ggiguash commented Dec 27, 2021

Uh oh!

ggiguash commented Jan 4, 2022

Uh oh!

openshift-ci Bot commented Jan 7, 2022

Uh oh!

ggiguash commented Jan 12, 2022

Uh oh!

ggiguash commented Jan 15, 2022

Uh oh!

ggiguash commented Jan 18, 2022

Uh oh!

eggfoobar commented Jan 24, 2022

Uh oh!

eggfoobar commented Jan 25, 2022

Uh oh!

dmage commented Jan 25, 2022

Uh oh!

dmage commented Jan 25, 2022

Uh oh!

openshift-ci Bot commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

openshift-ci Bot commented Jan 26, 2022

Uh oh!

openshift-ci Bot commented Jan 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

eggfoobar commented Dec 9, 2021 •

edited

Loading