Skip to content

bug 1801397: use a static pod manager #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deads2k wants to merge 16 commits into from
Closed

bug 1801397: use a static pod manager #112

deads2k wants to merge 16 commits into from

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 10, 2020

This PR bring all the disparate parts together to see if we can get the whole up and running.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@alaypatel07 alaypatel07 mentioned this pull request Feb 11, 2020
Closed
@deads2k deads2k force-pushed the big-picture branch 3 times, most recently from bbef31d to f098f02 Compare February 11, 2020 15:39
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2020
@deads2k deads2k mentioned this pull request Feb 11, 2020
Closed
@deads2k deads2k changed the title [wip] big picture bug 1801397: use a static pod manager Feb 11, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 11, 2020

@deads2k: This pull request references Bugzilla bug 1801397, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

bug 1801397: use a static pod manager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 11, 2020
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Feb 11, 2020

spoke on slack with @hexfusion . This passed bootstrapping last run. Found a condition ordering problem and fixed it.

We will go with this as soon as it can merge and build out from here. This unblocks

  1. removing DNS from startup flow
  2. fixing etcd member name to be node names
  3. removing DNS from kas flow
  4. removing old daemonset sync and status daemonsets

@hexfusion
Copy link
Contributor

hexfusion commented Feb 12, 2020

/lgtm

🥇

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 12, 2020
@deads2k deads2k mentioned this pull request Feb 12, 2020
Merged
@deads2k
Copy link
Contributor Author

deads2k commented Feb 13, 2020

/retest

@alaypatel07 alaypatel07 mentioned this pull request Feb 13, 2020
Merged
@deads2k
Copy link
Contributor Author

deads2k commented Feb 13, 2020

hit #144 on gcp

hit openshift/machine-config-operator#1473 on aws

@deads2k
Copy link
Contributor Author

deads2k commented Feb 14, 2020

[Conformance][Area:Networking][Feature:Router] The HAProxy router [Top Level] [Conformance][Area:Networking][Feature:Router] The HAProxy router should serve the correct routes when running with the haproxy config manager [Suite:openshift/conformance/parallel/minimal]
/retest

@deads2k
Copy link
Contributor Author

deads2k commented Feb 14, 2020

hit openshift/machine-config-operator#1473 on azure.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 14, 2020

/test all

@deads2k
Copy link
Contributor Author

deads2k commented Feb 14, 2020

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Feb 14, 2020 •
edited
Loading

Infra

/Restest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2020

@deads2k: you cannot LGTM your own PR.

Details

In response to this:

Infra

/Lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 14, 2020

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Feb 14, 2020

Alert
/Retest

@deads2k
Copy link
Contributor Author

deads2k commented Feb 14, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2020

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure caa8d56 link /test e2e-azure
ci/prow/e2e-gcp-upgrade caa8d56 link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 14, 2020

superceded by #142

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2020

@deads2k: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k deads2k closed this Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@hexfusion hexfusion

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deads2k @openshift-ci-robot @hexfusion @alaypatel07