Skip to content

bug 1804418: remove the etcd-member pod because we no longer need it #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 19, 2020
Merged

bug 1804418: remove the etcd-member pod because we no longer need it #1465

openshift-merge-robot merged 1 commit into from
Feb 19, 2020

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 12, 2020 •
edited
Loading

When combined with openshift/cluster-etcd-operator#112, we can get a working install and a working upgrade.

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2020
@deads2k deads2k mentioned this pull request Feb 13, 2020
Merged
@deads2k
Copy link
Contributor Author

deads2k commented Feb 14, 2020

this worked when combined into a payload with openshift/cluster-etcd-operator#142

@deads2k deads2k removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2020
@hexfusion
Copy link
Contributor

hexfusion commented Feb 14, 2020 •
edited
Loading

this has been manually tested with success.

this worked when combined into a payload with openshift/cluster-etcd-operator#142

confirming manual testing by @retroflexer and @sanchezl

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@sinnykumari
Copy link
Contributor

sinnykumari commented Feb 14, 2020

/hold
Needs a valid bug in order to get merged in master (4.4)
/retest

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2020
@alaypatel07 alaypatel07 mentioned this pull request Feb 14, 2020
Closed
@deads2k deads2k mentioned this pull request Feb 17, 2020
Closed
@deads2k
Copy link
Contributor Author

deads2k commented Feb 18, 2020

/hold cancel
/test all

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2020
@deads2k deads2k changed the title remove the etcd-member pod because we no longer need it bug 1804418: remove the etcd-member pod because we no longer need it Feb 18, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 18, 2020

@deads2k: This pull request references Bugzilla bug 1804418, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

bug 1804418: remove the etcd-member pod because we no longer need it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice
kikisdeliveryservice approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do this! =)

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Feb 18, 2020

/refresh

@deads2k
Copy link
Contributor Author

deads2k commented Feb 18, 2020

/retest
/refresh

@deads2k
Copy link
Contributor Author

deads2k commented Feb 19, 2020

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Feb 19, 2020

/cherry pick release-4.4

@deads2k
Copy link
Contributor Author

deads2k commented Feb 19, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5ed0aee into openshift:master Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2020

@deads2k: All pull requests linked via external trackers have merged. Bugzilla bug 1804418 has been moved to the MODIFIED state.

Details

In response to this:

bug 1804418: remove the etcd-member pod because we no longer need it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2020

@deads2k: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 fa78a85 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 19, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 19, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 19, 2020

@deads2k: new pull request created: #1487

Details

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Contributor

vrutkovs commented Feb 23, 2020

/cherrypick fcos

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 23, 2020

@vrutkovs: #1465 failed to apply on top of branch "fcos":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml deleted in remove the etcd-member pod because we no longer need it and modified in HEAD. Version HEAD of templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml left in tree.
Patch failed at 0001 remove the etcd-member pod because we no longer need it
Details

In response to this:

/cherrypick fcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs mentioned this pull request Feb 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

1 more reviewer

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hexfusion hexfusion

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@deads2k @hexfusion @sinnykumari @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @vrutkovs @kikisdeliveryservice @openshift-merge-robot