Skip to content

Conversation

@alaypatel07
Copy link
Contributor

@alaypatel07 alaypatel07 commented Feb 13, 2020

cherry-picking this from #112. This will unblock baremetal as
we no longer depend on NodeInternalDNS

fixes #115

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 13, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2020
@hexfusion
Copy link
Contributor

/test e2e-gcp

@hexfusion
Copy link
Contributor

this is blocking a lot of folks

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alaypatel07,hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion hexfusion changed the title remove dependency on node internal DNS name Bug 1801898: remove dependency on node internal DNS name Feb 13, 2020
@openshift-ci-robot
Copy link

@alaypatel07: This pull request references Bugzilla bug 1801898, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1801898: remove dependency on node internal DNS name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 13, 2020
@openshift-ci-robot
Copy link

@alaypatel07: This pull request references Bugzilla bug 1801898, which is valid.

Details

In response to this:

Bug 1801898: remove dependency on node internal DNS name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor

deads2k commented Feb 14, 2020

/hold

holding queue leading up to tomorrow

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2020
@LorbusChris
Copy link

It's not the internalDNS bug anymore that caused Azure to fail this time :) (looks like a Prom flake..)

/retest

@vrutkovs
Copy link

waiting for Prometheus: expected 2 replicas, updated 1 and available 1

/retest

@vrutkovs
Copy link

EncryptionKeyController_Error::EncryptionMigrationController_Error::EncryptionPruneController_Error::EncryptionStateController_Error: EncryptionMigrationControllerDegraded: daemonset.apps \"apiserver\" not found\nEncryptionPruneControllerDegraded: daemonset.apps \"apiserver\" not found\nEncryptionStateControllerDegraded: daemonset.apps \"apiserver\" not found\nEncryptionKeyControllerDegraded: daemonset.apps \"apiserver\" not found

/retest

@LorbusChris
Copy link

Urgh, Prom again!
/retest

@vrutkovs
Copy link

/test e2e-azure

@jdhirst
Copy link

jdhirst commented Feb 14, 2020

/retest

@jdhirst
Copy link

jdhirst commented Feb 15, 2020

All tests passed for this one, can it be merged?

@hexfusion
Copy link
Contributor

/hold cancel

We have other work to do on 142 and I would like to see these folks unblocked.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit d74495c into openshift:master Feb 15, 2020
@openshift-ci-robot
Copy link

@alaypatel07: All pull requests linked via external trackers have merged. Bugzilla bug 1801898 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1801898: remove dependency on node internal DNS name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node name inconsistencies across platforms.

9 participants