-
Notifications
You must be signed in to change notification settings - Fork 149
Bug 1801898: remove dependency on node internal DNS name #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1801898: remove dependency on node internal DNS name #143
Conversation
|
/test e2e-gcp |
|
this is blocking a lot of folks /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alaypatel07, hexfusion The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alaypatel07: This pull request references Bugzilla bug 1801898, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@alaypatel07: This pull request references Bugzilla bug 1801898, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold holding queue leading up to tomorrow |
|
It's not the internalDNS bug anymore that caused Azure to fail this time :) (looks like a Prom flake..) /retest |
|
/retest |
|
/retest |
|
Urgh, Prom again! |
|
/test e2e-azure |
|
/retest |
|
All tests passed for this one, can it be merged? |
|
/hold cancel We have other work to do on 142 and I would like to see these folks unblocked. |
|
@alaypatel07: All pull requests linked via external trackers have merged. Bugzilla bug 1801898 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherry-picking this from #112. This will unblock baremetal as
we no longer depend on
NodeInternalDNSfixes #115