add all etcd nodes to host-etcd resource #117
Conversation
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanchezl The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| Hostname: strings.TrimSuffix(address, "."+discoveryDomain), | ||
| IP: net.IPv4(byte(192), byte(0), byte(2), byte(i+1)).String(), | ||
| // create endpoint addresses for each node | ||
| pods, err := c.podLister.List(labels.Set{"k8s-app": "etcd"}.AsSelector()) |
There was a problem hiding this comment.
don't use pods. Get the nodes
|
|
||
| // if etcd-bootstrap exists, keep it (at the end of the list) | ||
| existing, err := c.endpointsLister.Endpoints("openshift-etcd").Get("host-etcd") | ||
| if err != nil && !errors.IsNotFound(err) { |
| if err != nil { | ||
| fmt.Errorf("unable to list expected etcd member nodes: %v", err) | ||
| } | ||
| endpointAddresses := &required.Subsets[0].Addresses |
There was a problem hiding this comment.
instead of this, create an empty one and then do an assignment at the end. it will be easier for slow people like me.
|
@sanchezl: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
also a verify failure. |
|
fixed in #123 |
3 participants
No description provided.