I bip #45
I bip #45
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tsorya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@tsorya: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
| cmdStart.Flags().StringSliceVar(&startOpts.requiredPodClauses, "required-pods", defaultRequiredPods, "List of pods name prefixes with their namespace (written as <namespace>/<pod-prefix>) that are required to be running and ready before the start command does the pivot, or alternatively a list of or'ed pod prefixes with a description (written as <desc>:<namespace>/<pod-prefix>|<namespace>/<pod-prefix>|...).") | ||
| cmdStart.Flags().StringVar(&startOpts.waitForTearDownEvent, "tear-down-event", "", "if this optional event name of the form <ns>/<event-name> is given, the event is waited for before tearing down the bootstrap control plane") | ||
| cmdStart.Flags().BoolVar(&startOpts.earlyTearDown, "tear-down-early", true, "tear down immediate after the non-bootstrap control plane is up and bootstrap-success event is created.") | ||
| cmdStart.Flags().StringVar(&startOpts.clusterProfile, "cluster-profile", "", "The cluster profile.") |
There was a problem hiding this comment.
what is this? What happens with the file? Add proper docs.
| bootstrapPodsRunningTimeout = 20 * time.Minute | ||
| // how long we wait until the assets must all be created | ||
| assetsCreatedTimeout = 60 * time.Minute | ||
| SingleNodeProductionEdge = "single-node-production-edge" |
There was a problem hiding this comment.
What is this? It is no edge. Is it a profile? Please name it that way.
| cancel() | ||
| if b.clusterProfile != SingleNodeProductionEdge { | ||
| cancel() | ||
| } |
There was a problem hiding this comment.
Adding this logic here and the knowledge that it depends on the profile IMO is wrong. Instead make the behaviour the feature, i.e. the flag: --terminte-early-when-pods-running.
|
/hold cluster-bootstrap should not know anything about profiles. Turn the profile logic into an explicit feature of cluster-bootstrap, i.e. something like |
| Use: "ibip", | ||
| Short: "Update the master ignition with control plane static pods files", | ||
| Long: "", | ||
| PreRunE: validateIBipOpts, |
|
closing this PR. there is a new updated PR targeting master |
6 participants
Adding ibip functionality by adding relevant files to masters ignition.
After adding files to ignition, bootkube.sh will run coreos-install with this ignition