Single Node deployment with bootstrap-in-place #46

eranco74 · 2020-12-15T10:32:12Z

No description provided.

openshift-ci-robot · 2020-12-15T10:32:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eranco74
To complete the pull request process, please assign deads2k after the PR has been reviewed.
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eranco74 · 2020-12-15T10:32:22Z

/hold

pkg/start/start.go

pkg/start/bootstrap.go

sttts · 2020-12-15T19:20:23Z

pkg/start/bootstrap.go

+	previousErrorSuffix := ""
+	var lastErr error
+	wait.Until(func() {
+		version, err := discovery.ServerVersion()


better check for /readyz, not discovey

@sttts till api is not ready it will not answer the call, In case of kubeapi it is not really relevant what to check. We just need to have any call to return. We can though move it to http call but i think this method is nicely tested in installer and is good enough for our needs

It will answer before /readyz. But you might get ugly errors for certain calls.

pkg/start/bootstrap.go

cmd/cluster-bootstrap/start.go

pkg/start/bootstrap.go

cmd/cluster-bootstrap/start.go

pkg/start/bootstrap.go

pkg/start/start.go

staebler · 2020-12-18T02:15:33Z

pkg/start/bootstrap.go

+	customTransport := http.DefaultTransport.(*http.Transport).Clone()
+	customTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
+	client := &http.Client{Transport: customTransport}
+	previousErrorSuffix := ""
+	wait.Until(func() {
+		_, err := client.Get(fmt.Sprintf("https://%s/readyz", b.kubeApiUrl))


My preference was how you had it originally--looking up ServerVersion via the discovery client. I don't like using InsecureSkipVerify, despite it being pretty benign here.

I prefer discovery client as well, this is less pretty but doesn't' require dependencies.
#46 (comment)

staebler · 2020-12-18T02:19:35Z

pkg/start/bootstrap.go

+		return err
+	}
+
+	return b.waitForApi()


Can you explain what problem this is looking to solve?

in case required-pods="" (this is the case when running bootstrap-in-place) cluster-bootstrap will fail to publish an event since kube-apiserver isn't up yet.
This should solve the problem by ensuring the kube-apiserver is available when bootstrapControlPlane.Start() returns.
I'll add it to the commit message

pkg/start/bootstrap.go

eranco74 · 2020-12-22T15:38:49Z

/unhold

in case required-pods="" (this is the case when running bootstrap-in-place) cluster-bootstrap may fail to publish an event in case kube-apiserver isn't up yet. This should solve the problem by ensuring the kube-apiserver is available

This means that we fail to create some manifests

Use fcct for creating the master ignition Signed-off-by: Eran Cohen <eran@stratoscale.com>

glide.yaml

pkg/start/bootstrap.go

cmd/cluster-bootstrap/bootstrapinplace.go

pkg/bootstrapinplace/bootstrapinplace.go

pkg/common/common.go

cmd/cluster-bootstrap/bootstrapinplace.go

pkg/start/bootstrap.go

pkg/start/bootstrap_test.go

eranco74 · 2021-01-14T12:51:38Z

Closing, see the updated PR based on top of go.mod PR

openshift-ci-robot requested review from deads2k and mfojtik December 15, 2020 10:32

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2020

eranco74 force-pushed the bootstrap-in-place branch 2 times, most recently from 7a7e7b7 to 35c8438 Compare December 15, 2020 11:31

eranco74 mentioned this pull request Dec 15, 2020

I bip #45

Closed

romfreiman mentioned this pull request Dec 15, 2020

Single Node deployment with bootstrap-in-place openshift/installer#4482

Merged

sttts reviewed Dec 15, 2020

View reviewed changes

pkg/start/start.go Outdated Show resolved Hide resolved

eranco74 force-pushed the bootstrap-in-place branch 3 times, most recently from febe942 to 473909d Compare December 15, 2020 17:35

sttts reviewed Dec 15, 2020

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

sttts reviewed Dec 15, 2020

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

sttts reviewed Dec 15, 2020

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

sttts reviewed Dec 15, 2020

View reviewed changes

cmd/cluster-bootstrap/start.go Outdated Show resolved Hide resolved

sttts reviewed Dec 15, 2020

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

sttts reviewed Dec 15, 2020

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

eranco74 force-pushed the bootstrap-in-place branch from 473909d to 7a2f87c Compare December 16, 2020 07:08

tsorya force-pushed the bootstrap-in-place branch 2 times, most recently from f771196 to 5907da0 Compare December 16, 2020 16:41

romfreiman mentioned this pull request Dec 16, 2020

single-node deployment with bootstrap-in-place openshift/enhancements#565

Merged

staebler reviewed Dec 18, 2020

View reviewed changes

crawford reviewed Dec 21, 2020

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

eranco74 force-pushed the bootstrap-in-place branch 3 times, most recently from 82d09d9 to 80b33a6 Compare December 22, 2020 14:30

eranco74 force-pushed the bootstrap-in-place branch from 066d750 to 80b33a6 Compare December 27, 2020 15:32

tsorya and others added 3 commits December 27, 2020 17:39

Wait for api after starting bootstrap control plane

70ddd20

in case required-pods="" (this is the case when running bootstrap-in-place) cluster-bootstrap may fail to publish an event in case kube-apiserver isn't up yet. This should solve the problem by ensuring the kube-apiserver is available

Retrun an error if waiting for assetsDone timed out.

a649ba9

This means that we fail to create some manifests

Added a flag for setting the assets creation timeout

3e64372

eranco74 force-pushed the bootstrap-in-place branch 6 times, most recently from 1ef73a3 to d3530db Compare December 29, 2020 07:05

eranco74 and others added 2 commits December 29, 2020 12:55

Adding bootstrap-in-place functionality

290d78b

Use fcct for creating the master ignition Signed-off-by: Eran Cohen <eran@stratoscale.com>

Added coreos/fcct to deps

6d7910f

eranco74 force-pushed the bootstrap-in-place branch from d3530db to 6d7910f Compare December 29, 2020 10:55

sttts reviewed Jan 4, 2021

View reviewed changes

glide.yaml Show resolved Hide resolved

sttts reviewed Jan 4, 2021

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

sttts reviewed Jan 4, 2021

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

sttts reviewed Jan 4, 2021

View reviewed changes

cmd/cluster-bootstrap/bootstrapinplace.go Show resolved Hide resolved

sttts reviewed Jan 4, 2021

View reviewed changes

pkg/bootstrapinplace/bootstrapinplace.go Show resolved Hide resolved

sttts reviewed Jan 4, 2021

View reviewed changes

pkg/common/common.go Outdated Show resolved Hide resolved

sttts reviewed Jan 5, 2021

View reviewed changes

cmd/cluster-bootstrap/bootstrapinplace.go Outdated Show resolved Hide resolved

sttts reviewed Jan 5, 2021

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

sttts reviewed Jan 5, 2021

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

sttts reviewed Jan 5, 2021

View reviewed changes

pkg/start/bootstrap.go Outdated Show resolved Hide resolved

sttts reviewed Jan 5, 2021

View reviewed changes

pkg/start/bootstrap_test.go Outdated Show resolved Hide resolved

tsorya force-pushed the bootstrap-in-place branch from cd5ba6f to e5d5e71 Compare January 5, 2021 17:28

tsorya added 2 commits January 6, 2021 13:13

Review fixes

0f61445

Adding comment for create master ignition function

b3b043f

tsorya force-pushed the bootstrap-in-place branch from e5d5e71 to b3b043f Compare January 6, 2021 11:14

eranco74 closed this Jan 14, 2021

Single Node deployment with bootstrap-in-place #46

Single Node deployment with bootstrap-in-place #46

Uh oh!

Conversation

eranco74 commented Dec 15, 2020

Uh oh!

openshift-ci-robot commented Dec 15, 2020

Uh oh!

eranco74 commented Dec 15, 2020

Uh oh!

Uh oh!

Uh oh!

sttts Dec 15, 2020

Choose a reason for hiding this comment

Uh oh!

tsorya Dec 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sttts Jan 4, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

staebler Dec 18, 2020

Choose a reason for hiding this comment

Uh oh!

eranco74 Dec 22, 2020

Choose a reason for hiding this comment

Uh oh!

staebler Dec 18, 2020

Choose a reason for hiding this comment

Uh oh!

eranco74 Dec 22, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eranco74 commented Dec 22, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eranco74 commented Jan 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tsorya Dec 16, 2020 •

edited

Loading