Skip to content

Igal/ibip #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tsorya wants to merge 6 commits into from
Closed

Igal/ibip #44

tsorya wants to merge 6 commits into from

Conversation

@tsorya
Copy link
Contributor

@tsorya tsorya commented Dec 13, 2020 •
edited
Loading

Adding ibip functionality by adding relevant files to masters ignition.
After adding files to ignition, bootkube.sh will run coreos-install with this ignition

openshift-bot and others added 4 commits December 6, 2020 13:24
@openshift-bot @eranco74
Updating Dockerfile baseimages to mach ocp-build-data config
f7e55b5 
This PR is autogenerated by the [ocp-build-data-enforcer][1].
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the [ocp-build-data repository][2] used
for producing release artifacts.

If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.

[1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer
[2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
@openshift-bot @eranco74
Updating Dockerfile baseimages to mach ocp-build-data config
2493789 
This PR is autogenerated by the [ocp-build-data-enforcer][1].
It updates the base images in the Dockerfile used for promotion in order to ensure it
matches the configuration in the [ocp-build-data repository][2] used
for producing release artifacts.

Instead of merging this PR you can also create an alternate PR that includes the changes found here.

If you believe the content of this PR is incorrect, please contact the dptp team in
#aos-art.

[1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer
[2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6/images
@eranco74
MGMT-3172 Added single-node-production-edge cluster profile support
f11755f
@eranco74
Return an error in case we fail to apply manifests
2ee6c72
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tsorya
To complete the pull request process, please assign mfojtik after the PR has been reviewed.
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsorya
Copy link
Contributor Author

tsorya commented Dec 13, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2020

@tsorya: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 13, 2020

@tsorya: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/images 7df4ceb link /test images
ci/prow/verify-deps 7df4ceb link /test verify-deps
ci/prow/unit 7df4ceb link /test unit
ci/prow/verify 7df4ceb link /test verify
ci/prow/e2e-aws 7df4ceb link /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tsorya tsorya closed this Dec 13, 2020
@romfreiman
Copy link

romfreiman commented Dec 13, 2020

Replaced by #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tsorya @openshift-ci-robot @openshift-merge-robot @romfreiman @openshift-bot @eranco74