-
Notifications
You must be signed in to change notification settings - Fork 48
I bip #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I bip #45
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,7 @@ const ( | |
| bootstrapPodsRunningTimeout = 20 * time.Minute | ||
| // how long we wait until the assets must all be created | ||
| assetsCreatedTimeout = 60 * time.Minute | ||
| SingleNodeProductionEdge = "single-node-production-edge" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is this? It is no edge. Is it a profile? Please name it that way. |
||
| ) | ||
|
|
||
| type Config struct { | ||
|
|
@@ -35,6 +36,7 @@ type Config struct { | |
| RequiredPodPrefixes map[string][]string | ||
| WaitForTearDownEvent string | ||
| EarlyTearDown bool | ||
| ClusterProfile string | ||
| } | ||
|
|
||
| type startCommand struct { | ||
|
|
@@ -44,6 +46,7 @@ type startCommand struct { | |
| requiredPodPrefixes map[string][]string | ||
| waitForTearDownEvent string | ||
| earlyTearDown bool | ||
| clusterProfile string | ||
| } | ||
|
|
||
| func NewStartCommand(config Config) (*startCommand, error) { | ||
|
|
@@ -54,6 +57,7 @@ func NewStartCommand(config Config) (*startCommand, error) { | |
| requiredPodPrefixes: config.RequiredPodPrefixes, | ||
| waitForTearDownEvent: config.WaitForTearDownEvent, | ||
| earlyTearDown: config.EarlyTearDown, | ||
| clusterProfile: config.ClusterProfile, | ||
| }, nil | ||
| } | ||
|
|
||
|
|
@@ -127,7 +131,9 @@ func (b *startCommand) Run() error { | |
| if err = waitUntilPodsRunning(ctx, client, b.requiredPodPrefixes); err != nil { | ||
| return err | ||
| } | ||
| cancel() | ||
| if b.clusterProfile != SingleNodeProductionEdge { | ||
| cancel() | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding this logic here and the knowledge that it depends on the profile IMO is wrong. Instead make the behaviour the feature, i.e. the flag: |
||
| assetsDone.Wait() | ||
|
|
||
| // notify installer that we are ready to tear down the temporary bootstrap control plane | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this? What happens with the file? Add proper docs.