Update BMH CRD

[hardys]

This is to align with the rebase proposed via:
openshift/baremetal-operator#133

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys, kirankt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hardys,kirankt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sadasu]

This CRD change needs to be made here https://github.com/openshift/cluster-baremetal-operator/blob/master/api/v1alpha1/provisioning_types.go. "make manifests" will take care of actually generating the manifest.

[hardys]

This CRD change needs to be made here https://github.com/openshift/cluster-baremetal-operator/blob/master/api/v1alpha1/provisioning_types.go. "make manifests" will take care of actually generating the manifest.

This is updating the BMH CRD from the BMO repo, via hack/get-bmh-crd.sh - this just copies the yaml, and the provisioning_types.go does not contain any code definition of the BMH resource AFAICS:

$ grep type provisioning_types.go 
type ProvisioningNetwork string
type ProvisioningSpec struct {
type ProvisioningStatus struct {
type Provisioning struct {
type ProvisioningList struct {

That also wasn't the approach used in #105 #100 #78 #70 #64 #51 so perhaps @honza can confirm, but I think this is the right process?

[honza]

You should be able to use the hack/get-bmh-crd.sh script to update the CRD. As mentioned above, this process isn't fully automatic. You'll need to tweak the CRD after running the script: the script deletes some annotations already in the CBO that we need to keep.

[hardys]

/retest

[hardys]

/retest

[hardys]

/test e2e-metal-ipi

[honza]

/lgtm

[sadasu]

This CRD change needs to be made here https://github.com/openshift/cluster-baremetal-operator/blob/master/api/v1alpha1/provisioning_types.go. "make manifests" will take care of actually generating the manifest.

This is updating the BMH CRD from the BMO repo, via hack/get-bmh-crd.sh - this just copies the yaml, and the provisioning_types.go does not contain any code definition of the BMH resource AFAICS:

$ grep type provisioning_types.go 
type ProvisioningNetwork string
type ProvisioningSpec struct {
type ProvisioningStatus struct {
type Provisioning struct {
type ProvisioningList struct {

That also wasn't the approach used in #105 #100 #78 #70 #64 #51 so perhaps @honza can confirm, but I think this is the right process?

That is correct.